Skip to content

Commit

Permalink
updates.html: include satisfied requirements in the table
Browse files Browse the repository at this point in the history
I noticed today that tests which are 'required' aren't marked
as such in the Bodhi webUI if they passed. Only queued or failed
or missing tests are shown as 'required' (as shown by the
black asterisk with a mouseover comment, on the Automated Tests
tab). This is because we're not pushing satifised requirements
into the list that's used to track which tests are required.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

end
  • Loading branch information
AdamWill committed Jun 23, 2023
1 parent 5a869a7 commit 725e1f9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions bodhi-server/bodhi/server/templates/update.html
Original file line number Diff line number Diff line change
Expand Up @@ -900,6 +900,12 @@ <h3 class="modal-title" id="waiveModalLabel">Trigger Tests</h3>
waivers[waiver.testcase].push(waiver);
});
handle_unsatisfied_requirements(data);
$.each(data['satisfied_requirements'], function(i, requirement) {
// the user may have already specified this in the required taskotron tests
if ($.inArray(requirement.testcase, requirements) == -1) {
requirements.push(requirement.testcase);
}
});
reqs_counter += data['unsatisfied_requirements'].length;
reqs_counter += data['satisfied_requirements'].length;
handle_results(data.results, request.subject);
Expand Down
1 change: 1 addition & 0 deletions news/PR5388.bug
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
On the Automated Tests tab, passed tests that are 'required' now correctly show as such

0 comments on commit 725e1f9

Please sign in to comment.