Results page redesign, final part

package.json

@@ -38,6 +38,7 @@
     "react-redux": "^8.1.1",
     "react-router-dom": "^6.11.2",
     "react-scripts": "5.0.1",
+    "react-use-localstorage": "^3.5.3",
     "redux": "^4.2.1",
     "typescript": "^5.1.3",
     "uuid": "^9.0.0",
@@ -51,7 +52,7 @@
   "scripts": {
     "start": "react-scripts start",
     "build": "react-scripts build",
-    "test": "react-scripts test",
+    "test": "TZ=Europe/Prague react-scripts test",
     "eslint": "eslint .",
     "eject": "react-scripts eject"
   },

src/actions/index.tsx

@@ -29,10 +29,10 @@ import * as authSlice from '../slices/authSlice';
 import * as filtersSlice from '../slices/filtersSlice';
 import * as gatingTestsFormSlice from '../slices/gatingTestsFormSlice';
 import * as waiveSlice from '../slices/waiveSlice';
-import { Artifact, PayloadRPMBuildType, StateType } from '../artifact';
+import { Artifact, PayloadRPMBuildType } from '../artifact';
 import { greenwave } from '../config';
 import WaiverdbNewMutation from '../mutations/WaiverdbNew';
-import { db_field_from_atype, getTestcaseName } from '../utils/artifactUtils';
+import { db_field_from_atype } from '../utils/artifactUtils';
 
 export const cleanseGatingFormState = () => gatingTestsFormSlice.cleanse();
 
@@ -130,7 +130,7 @@ export const fetchUser = () => {
 
 export const createWaiver = (
     artifact: Artifact | undefined,
-    state: StateType | undefined,
+    testcase: string | undefined,
 ) => {
     return async (dispatch: AppDispatch, getState: GetState) => {
         const { displayName, nameID } = getState().auth;
@@ -146,7 +146,7 @@ export const createWaiver = (
             );
             return;
         }
-        dispatch(waiveSlice.createWaiver({ artifact, state }));
+        dispatch(waiveSlice.createWaiver({ artifact, testcase }));
     };
 };
 
@@ -167,8 +167,8 @@ export const submitWaiver = (reason: string, client: ApolloClient<object>) => {
          * get NVR, for modules we need to convert it to 'brew' like form
          */
         let waiveError: string;
-        const { artifact, state } = getState().waive;
-        if (_.isNil(_.get(artifact, 'payload.nvr')) || _.isNil(state)) {
+        const { artifact, testcase } = getState().waive;
+        if (_.isNil(_.get(artifact, 'payload.nvr')) || _.isNil(testcase)) {
             return;
         }
         // NOTE: We know that artifact.payload is not null thanks to the check at the
@@ -190,7 +190,6 @@ export const submitWaiver = (reason: string, client: ApolloClient<object>) => {
         if (artifactType === 'brew-build' && nvr.match(/.*-container-.*/)) {
             artifactType = 'redhat-container-image';
         }
-        let testcase: string = getTestcaseName(state);
         const product_version = greenwave.decision.product_version(
             nvr,
             artifactType,

src/actions/types.ts

@@ -19,7 +19,7 @@
  */
 
 import { AlertVariant } from '@patternfly/react-core';
 import { Artifact, StateType } from '../artifact';
 import React from 'react';
 
 export const SST_PAGE = 'SST_PAGE';
@@ -57,7 +57,7 @@
 export interface IStateWaiver {
     artifact?: Artifact;
     reason: string;
-    state?: StateType;
+    testcase?: string;
     timestamp?: number;
     waiveError: string;
 }
@@ -105,8 +105,8 @@
 }
 
 export interface CreateWaiverPayload {
-    state: StateType | undefined;
     artifact: Artifact | undefined;
+    testcase: string | undefined;
 }
 
 export interface SubmitWaiverPayload {

src/artifact.ts

@@ -19,7 +19,7 @@
  */
 
 import _ from 'lodash';
-import { BrokerMessagesType, EtaBrokerMessagesType } from './types';
+import { BrokerMessagesType, EtaBrokerMessagesType, Metadata } from './types';
 
 export type ComposeArtifactType = 'productmd-compose';
 export type ContainerImageArtifactType = 'redhat-container-image';
@@ -103,27 +103,39 @@ export function isArtifactRPM(artifact: Artifact): artifact is ArtifactRPM {
         artifact.type === 'koji-build-cs'
     );
 }
+
 export function isArtifactMBS(artifact: Artifact): artifact is ArtifactMBS {
     return artifact.type === 'redhat-module';
 }
+
 export function isArtifactCompose(
     artifact: Artifact,
 ): artifact is ArtifactCompose {
     return artifact.type === 'productmd-compose';
 }
+
 export function isArtifactRedhatContainerImage(
     artifact: Artifact,
 ): artifact is ArtifactContainerImage {
     return artifact.type === 'redhat-container-image';
 }
+
 export function isStateKai(state: StateType): state is StateKaiType {
     return _.has(state, 'kai_state');
 }
 
-export type PayloadsType =
-    | PayloadComposeBuildType
-    | PayloadMBSBuildType
-    | PayloadRPMBuildType;
+export function isArtifactScratch(artifact: Artifact): boolean {
+    if (
+        isArtifactRedhatContainerImage(artifact) ||
+        isArtifactMBS(artifact) ||
+        isArtifactRPM(artifact)
+    ) {
+        return artifact.payload.scratch;
+    }
+    return false;
+}
+
+export type PayloadsType = Artifact['payload'];
 
 export interface ArtifactBase {
     _id: string;
@@ -201,6 +213,15 @@ export type GreenwaveRequirementType = {
     item: { type: ArtifactType; identifier: string };
 };
 
+export type GreenwaveRequirementOutcome =
+    | 'INFO'
+    | 'ERROR'
+    | 'PASSED'
+    | 'FAILED'
+    | 'RUNNING'
+    | 'NOT_APPLICABLE'
+    | 'NEEDS_INSPECTION';
+
 /**
  * Based on documentation from:
  * https://pagure.io/greenwave/blob/master/f/greenwave/api_v1.py
@@ -228,24 +249,25 @@ export type GreenwaveRequirementType = {
 export type GreenwaveResultType = {
     data: {
         brew_task_id: string[];
-        category: string[];
-        ci_email: string[];
-        ci_irc: string[];
-        ci_name: string[];
-        ci_team: string[];
-        ci_url: string[];
-        component: string[];
-        issuer: string[];
+        category?: string[];
+        ci_docs?: string[];
+        ci_email?: string[];
+        ci_irc?: string[];
+        ci_name?: string[];
+        ci_team?: string[];
+        ci_url?: string[];
+        component?: string[];
+        issuer?: string[];
         item: string[];
-        log: string[];
+        log?: string[];
         msg_id: string[];
-        publisher_id: string[];
-        rebuild: string[];
+        publisher_id?: string[];
+        rebuild?: string[];
         scratch: string[];
-        system_os: string[];
-        system_provider: string[];
-        arch: string[];
-        seconds_taken: string[];
+        system_os?: string[];
+        system_provider?: string[];
+        arch?: string[];
+        seconds_taken?: string[];
         type: ArtifactType[];
     };
     groups: string[];
@@ -258,14 +280,7 @@ export type GreenwaveResultType = {
      * https://pagure.io/fedora-ci/messages/blob/master/f/mappings/results/brew-build.test.complete.yaml#_3
      * https://pagure.io/fedora-ci/messages/blob/master/f/mappings/results/brew-build.test.error.yaml#_3
      */
-    outcome:
-        | 'INFO'
-        | 'ERROR'
-        | 'PASSED'
-        | 'FAILED'
-        | 'RUNNING'
-        | 'NOT_APPLICABLE'
-        | 'NEEDS_INSPECTION';
+    outcome: GreenwaveRequirementOutcome;
     /**
      * ref_url - always run.url, for old and new mapping:
      * https://github.com/release-engineering/resultsdb-updater/blob/master/resultsdbupdater/utils.py#L343
@@ -401,6 +416,7 @@ export interface KaiErrataToolAutomationStateType {
 
 export type StateKaiType = {
     broker_msg_body: BrokerMessagesType;
+    custom_metadata?: Metadata;
     kai_state: KaiStateType;
 };