-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Results page redesign, final part #209
Commits on Jul 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f8ad928 - Browse repository at this point
Copy the full SHA f8ad928View commit details -
Configuration menu - View commit details
-
Copy full SHA for 936cc9d - Browse repository at this point
Copy the full SHA 936cc9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c7a096 - Browse repository at this point
Copy the full SHA 6c7a096View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44aa908 - Browse repository at this point
Copy the full SHA 44aa908View commit details -
Configuration menu - View commit details
-
Copy full SHA for db45877 - Browse repository at this point
Copy the full SHA db45877View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb2c288 - Browse repository at this point
Copy the full SHA bb2c288View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16b1743 - Browse repository at this point
Copy the full SHA 16b1743View commit details -
Move all header components into separate module
- Show task ID in page header.
Configuration menu - View commit details
-
Copy full SHA for fd797ae - Browse repository at this point
Copy the full SHA fd797aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21fe8fe - Browse repository at this point
Copy the full SHA 21fe8feView commit details -
Utility function for timestamp formatting
In order to make the tests reproducible and consistent, the `TZ` environment variable is fixed to Europe/Prague for tests.
Configuration menu - View commit details
-
Copy full SHA for e2dbaa4 - Browse repository at this point
Copy the full SHA e2dbaa4View commit details -
Display real data in "Build summary", "Active tags" and "Tagging history" tabs.
Configuration menu - View commit details
-
Copy full SHA for 96e1e7a - Browse repository at this point
Copy the full SHA 96e1e7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0623945 - Browse repository at this point
Copy the full SHA 0623945View commit details -
Load data for user-specified artifact
Load information on the artifact specified by user in the URL dynamically. This allows, among other things, to show the correct NVR, gating tag, gating status and task ID in the page header.
Configuration menu - View commit details
-
Copy full SHA for 4b311e9 - Browse repository at this point
Copy the full SHA 4b311e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ca7fde - Browse repository at this point
Copy the full SHA 0ca7fdeView commit details -
Refactor the `isResultWaivable` and `isResultMissing` functions so that they're applicable to any state type.
Configuration menu - View commit details
-
Copy full SHA for 1bea8d4 - Browse repository at this point
Copy the full SHA 1bea8d4View commit details -
Display names and statuses of known test results for a given artifact as they're stored in the database.
Configuration menu - View commit details
-
Copy full SHA for 9bfa215 - Browse repository at this point
Copy the full SHA 9bfa215View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64b5964 - Browse repository at this point
Copy the full SHA 64b5964View commit details -
Make sure all test results are listed
Interpret `NEEDS_INSPECTION` and `NOT_APPLICABLE` outcomes from Greenwave as failed for required tests. This makes them appear in the topmost section of the results table with the rest of the failed tests.
Configuration menu - View commit details
-
Copy full SHA for 11690e6 - Browse repository at this point
Copy the full SHA 11690e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e073218 - Browse repository at this point
Copy the full SHA e073218View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1c4ad4 - Browse repository at this point
Copy the full SHA a1c4ad4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a10998 - Browse repository at this point
Copy the full SHA 2a10998View commit details -
Configuration menu - View commit details
-
Copy full SHA for b104fc4 - Browse repository at this point
Copy the full SHA b104fc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02bf8d8 - Browse repository at this point
Copy the full SHA 02bf8d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2d3117 - Browse repository at this point
Copy the full SHA d2d3117View commit details -
Add the blue info icon for the `info`, `needs_inspection` and `not_applicable` statuses.
Configuration menu - View commit details
-
Copy full SHA for 127222c - Browse repository at this point
Copy the full SHA 127222cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a55699b - Browse repository at this point
Copy the full SHA a55699bView commit details -
Configuration menu - View commit details
-
Copy full SHA for daa0a96 - Browse repository at this point
Copy the full SHA daa0a96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20322ca - Browse repository at this point
Copy the full SHA 20322caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f33bd8 - Browse repository at this point
Copy the full SHA 4f33bd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58556bb - Browse repository at this point
Copy the full SHA 58556bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa1f557 - Browse repository at this point
Copy the full SHA fa1f557View commit details -
Configuration menu - View commit details
-
Copy full SHA for 294d4ec - Browse repository at this point
Copy the full SHA 294d4ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdc21dc - Browse repository at this point
Copy the full SHA fdc21dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 553e922 - Browse repository at this point
Copy the full SHA 553e922View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16c0587 - Browse repository at this point
Copy the full SHA 16c0587View commit details -
Configuration menu - View commit details
-
Copy full SHA for 443c618 - Browse repository at this point
Copy the full SHA 443c618View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e5f1c4 - Browse repository at this point
Copy the full SHA 2e5f1c4View commit details
Commits on Jul 26, 2023
-
Make waive button component accept testcase name
Make the waive button component for testcase accept the testcase name instead of the whole state type. This disentangles the details of the state type from the implementation of the button and makes the control/data flow simpler in some places.
Configuration menu - View commit details
-
Copy full SHA for e1a7aa6 - Browse repository at this point
Copy the full SHA e1a7aa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7d3c79 - Browse repository at this point
Copy the full SHA a7d3c79View commit details -
Remove 'waived' from valid test statuses
Being waived is seldom a useful distinct status – even when a test is waived, we might still want to know what its original outcome was. Therefore, remove the `waived` status and instead use a boolean flag wherever we need to know the waive status, e.g. in the `TestStatusIcon` component in this case.
Configuration menu - View commit details
-
Copy full SHA for be89a3c - Browse repository at this point
Copy the full SHA be89a3cView commit details -
Refactor DetailsDrawer component
Move conditional children components into function-level variables to simplify the JSX chunks a bit.
Configuration menu - View commit details
-
Copy full SHA for 223ebf2 - Browse repository at this point
Copy the full SHA 223ebf2View commit details -
Display known issues correctly
Show the "Known issues" tab in the details drawer with the list of issues as provided by CI maintainers. If no known issues have been entered, hide the tab.
Configuration menu - View commit details
-
Copy full SHA for 6033221 - Browse repository at this point
Copy the full SHA 6033221View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59253a8 - Browse repository at this point
Copy the full SHA 59253a8View commit details -
Move new results page to the /artifact/... route
Move the new test results page to the primary URL, i.e. the `/artifact/:type/:search/:value` route. Move the old page to `/resultsold/...`, for example `/resultsold/brew-build/aid/53823788`. The page only displays the first results for now, this will be extended later.
Configuration menu - View commit details
-
Copy full SHA for 70331e3 - Browse repository at this point
Copy the full SHA 70331e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa19bf6 - Browse repository at this point
Copy the full SHA aa19bf6View commit details -
Show test case description from custom metadata
Show test description provided by CI maintainers via custom metadata, if available.
Configuration menu - View commit details
-
Copy full SHA for 5f8ccd9 - Browse repository at this point
Copy the full SHA 5f8ccd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b8b433 - Browse repository at this point
Copy the full SHA 9b8b433View commit details -
More utility functions for artifacts
Add functions to extract gating tag and isseuer name from artifact, if available.
Configuration menu - View commit details
-
Copy full SHA for 9cfb3d3 - Browse repository at this point
Copy the full SHA 9cfb3d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b8debf - Browse repository at this point
Copy the full SHA 2b8debfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e8d8a6 - Browse repository at this point
Copy the full SHA 0e8d8a6View commit details -
- Allow the new results page to display results for all supported artifact types – RPM (Koji/Brew) builds, as well as module (MBS) builds, containers builds, composes, etc. - Show detailed build metadata for module builds. - Show Components tab for module builds and do not query for related advisories as module builds are not supported.
Configuration menu - View commit details
-
Copy full SHA for 5a77a98 - Browse repository at this point
Copy the full SHA 5a77a98View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff1be62 - Browse repository at this point
Copy the full SHA ff1be62View commit details -
Generalize and reuse TagsList component
Generalize the `TagsList` component to be able to display Koji taks for module builds as well.
Configuration menu - View commit details
-
Copy full SHA for c883a88 - Browse repository at this point
Copy the full SHA c883a88View commit details -
Fix waiving on new results page
Include the `WaiveForm` and `ToastAlertGroup` components in the new results page so that the waiving UI works as expected.
Configuration menu - View commit details
-
Copy full SHA for bf1b747 - Browse repository at this point
Copy the full SHA bf1b747View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3330d7 - Browse repository at this point
Copy the full SHA b3330d7View commit details -
Pass the whole `CiTest` to individual results table row components to reduce repetition and remove the newly redundant props.
Configuration menu - View commit details
-
Copy full SHA for ff58b4c - Browse repository at this point
Copy the full SHA ff58b4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 195f989 - Browse repository at this point
Copy the full SHA 195f989View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2696b0 - Browse repository at this point
Copy the full SHA a2696b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fc1152 - Browse repository at this point
Copy the full SHA 8fc1152View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5486ec - Browse repository at this point
Copy the full SHA a5486ecView commit details -
Reuse existing componets for test suites
Use already existing components to display test cases within a suite and their logs, test phases, etc. Moreover, do a little refactoring for clarity and composability by moving some chunks into names variables or functions.
Configuration menu - View commit details
-
Copy full SHA for e39b419 - Browse repository at this point
Copy the full SHA e39b419View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98c72dc - Browse repository at this point
Copy the full SHA 98c72dcView commit details -
Dispense with a couple of TODOs
Removed several outdated TODOs and fix those that are easy to fix.
Configuration menu - View commit details
-
Copy full SHA for 29e1f9c - Browse repository at this point
Copy the full SHA 29e1f9cView commit details -
Display dynamic title on new results page
Similar to the old behavior showing the artifact name and gating status, if available.
Configuration menu - View commit details
-
Copy full SHA for 55b2472 - Browse repository at this point
Copy the full SHA 55b2472View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bcb28c - Browse repository at this point
Copy the full SHA 1bcb28cView commit details -
Load contact info for missing tests dynamically
We know that a test is missing thanks to Greenwave, but we do not have any contact-related metadata coming from that channel, so we have to pull contact metadata on an as-needed basis if the test is missing.
Configuration menu - View commit details
-
Copy full SHA for 8b71a51 - Browse repository at this point
Copy the full SHA 8b71a51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e99395 - Browse repository at this point
Copy the full SHA 4e99395View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef43eff - Browse repository at this point
Copy the full SHA ef43effView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f888c6 - Browse repository at this point
Copy the full SHA 5f888c6View commit details -
Make sure to store the requested focus test so that we can look it up later, once all the tests have been loaded. This ensures that if you select a test and refresh the page, it will expand automatically. This was broken previously because the `useEffect()` hook only runs on first render and when the query parameters change. When this happens at page load, the `tests` variable is not yet populated becuse the query has not finished yet. Therefore the correct test could not have been looked up at this point in time.
Configuration menu - View commit details
-
Copy full SHA for 05a8d64 - Browse repository at this point
Copy the full SHA 05a8d64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8092cd4 - Browse repository at this point
Copy the full SHA 8092cd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcd9fa5 - Browse repository at this point
Copy the full SHA dcd9fa5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4147d5 - Browse repository at this point
Copy the full SHA b4147d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for df621c6 - Browse repository at this point
Copy the full SHA df621c6View commit details -
Adjust the search results table according to the UXD mock-up. Use a minimalist table with clickable rows that take you to the single-artifact view instead of a table with various expandable rows. Pagination is not yet implemented in this version.
Configuration menu - View commit details
-
Copy full SHA for d83d708 - Browse repository at this point
Copy the full SHA d83d708View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24f6af6 - Browse repository at this point
Copy the full SHA 24f6af6View commit details -
Minor refactoring of SearchToolbar
Clean up code a bit without changing behaviour.
Configuration menu - View commit details
-
Copy full SHA for 0598bac - Browse repository at this point
Copy the full SHA 0598bacView commit details -
Refactor new artifacts list component
Refactor the `ArtifactsListNew` component to make it pure and reusable across different scenarios. Move the `useQuery()` call out to the parent component and insert a business-logic component between the list and the `PageByFilters` component.
Configuration menu - View commit details
-
Copy full SHA for e7920a2 - Browse repository at this point
Copy the full SHA e7920a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 912582d - Browse repository at this point
Copy the full SHA 912582dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fa2555 - Browse repository at this point
Copy the full SHA 6fa2555View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac6920e - Browse repository at this point
Copy the full SHA ac6920eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e0f38e - Browse repository at this point
Copy the full SHA 0e0f38eView commit details