Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results page redesign, final part #209

Merged
merged 82 commits into from
Jul 27, 2023
Merged

Results page redesign, final part #209

merged 82 commits into from
Jul 27, 2023

Commits on Jul 18, 2023

  1. Configuration menu
    Copy the full SHA
    f8ad928 View commit details
    Browse the repository at this point in the history
  2. Change fake email address

    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    936cc9d View commit details
    Browse the repository at this point in the history
  3. Add TODOs for fake data

    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    6c7a096 View commit details
    Browse the repository at this point in the history
  4. Refactor for readability

    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    44aa908 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    db45877 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bb2c288 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    16b1743 View commit details
    Browse the repository at this point in the history
  8. Move all header components into separate module

    - Show task ID in page header.
    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    fd797ae View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    21fe8fe View commit details
    Browse the repository at this point in the history
  10. Utility function for timestamp formatting

    In order to make the tests reproducible and consistent, the `TZ`
    environment variable is fixed to Europe/Prague for tests.
    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    e2dbaa4 View commit details
    Browse the repository at this point in the history
  11. Display more real information

    Display real data in "Build summary", "Active tags" and "Tagging
    history" tabs.
    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    96e1e7a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    0623945 View commit details
    Browse the repository at this point in the history
  13. Load data for user-specified artifact

    Load information on the artifact specified by user in the URL
    dynamically. This allows, among other things, to show the correct NVR, gating
    tag, gating status and task ID in the page header.
    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    4b311e9 View commit details
    Browse the repository at this point in the history
  14. Show related advisories

    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    0ca7fde View commit details
    Browse the repository at this point in the history
  15. Refactor for generality

    Refactor the `isResultWaivable` and `isResultMissing` functions so that
    they're applicable to any state type.
    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    1bea8d4 View commit details
    Browse the repository at this point in the history
  16. Display real test results

    Display names and statuses of known test results for a given artifact as
    they're stored in the database.
    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    9bfa215 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    64b5964 View commit details
    Browse the repository at this point in the history
  18. Make sure all test results are listed

    Interpret `NEEDS_INSPECTION` and `NOT_APPLICABLE` outcomes from Greenwave as
    failed for required tests. This makes them appear in the topmost section
    of the results table with the rest of the failed tests.
    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    11690e6 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    e073218 View commit details
    Browse the repository at this point in the history
  20. Make re-run buttons work

    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    a1c4ad4 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    2a10998 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    b104fc4 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    02bf8d8 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    d2d3117 View commit details
    Browse the repository at this point in the history
  25. Support more status icons

    Add the blue info icon for the `info`, `needs_inspection` and
    `not_applicable` statuses.
    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    127222c View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    a55699b View commit details
    Browse the repository at this point in the history
  27. Support module builds

    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    daa0a96 View commit details
    Browse the repository at this point in the history
  28. Support permalinks for tests

    Reference: OSCI-4469
    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    20322ca View commit details
    Browse the repository at this point in the history
  29. Show waivers in drawer

    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    4f33bd8 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    58556bb View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    fa1f557 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    294d4ec View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    fdc21dc View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    553e922 View commit details
    Browse the repository at this point in the history
  35. More natural contact info

    mgrabovsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    16c0587 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    443c618 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    2e5f1c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Make waive button component accept testcase name

    Make the waive button component for testcase accept the testcase name
    instead of the whole state type. This disentangles the details of the
    state type from the implementation of the button and makes the
    control/data flow simpler in some places.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    e1a7aa6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a7d3c79 View commit details
    Browse the repository at this point in the history
  3. Remove 'waived' from valid test statuses

    Being waived is seldom a useful distinct status – even when a test is
    waived, we might still want to know what its original outcome was.
    Therefore, remove the `waived` status and instead use a boolean flag
    wherever we need to know the waive status, e.g. in the `TestStatusIcon`
    component in this case.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    be89a3c View commit details
    Browse the repository at this point in the history
  4. Refactor DetailsDrawer component

    Move conditional children components into function-level variables to
    simplify the JSX chunks a bit.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    223ebf2 View commit details
    Browse the repository at this point in the history
  5. Display known issues correctly

    Show the "Known issues" tab in the details drawer with the list of
    issues as provided by CI maintainers. If no known issues have been
    entered, hide the tab.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6033221 View commit details
    Browse the repository at this point in the history
  6. Add Errata automation tab

    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    59253a8 View commit details
    Browse the repository at this point in the history
  7. Move new results page to the /artifact/... route

    Move the new test results page to the primary URL, i.e. the
    `/artifact/:type/:search/:value` route. Move the old page to
    `/resultsold/...`, for example `/resultsold/brew-build/aid/53823788`.
    
    The page only displays the first results for now, this will be extended
    later.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    70331e3 View commit details
    Browse the repository at this point in the history
  8. Separate links by a bullet

    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    aa19bf6 View commit details
    Browse the repository at this point in the history
  9. Show test case description from custom metadata

    Show test description provided by CI maintainers via custom metadata, if
    available.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5f8ccd9 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9b8b433 View commit details
    Browse the repository at this point in the history
  11. More utility functions for artifacts

    Add functions to extract gating tag and isseuer name from artifact, if
    available.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9cfb3d3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2b8debf View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    0e8d8a6 View commit details
    Browse the repository at this point in the history
  14. Support all artifact types

    - Allow the new results page to display results for all supported
      artifact types – RPM (Koji/Brew) builds, as well as module (MBS)
      builds, containers builds, composes, etc.
    - Show detailed build metadata for module builds.
    - Show Components tab for module builds and do not query for related
      advisories as module builds are not supported.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5a77a98 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    ff1be62 View commit details
    Browse the repository at this point in the history
  16. Generalize and reuse TagsList component

    Generalize the `TagsList` component to be able to display Koji taks for
    module builds as well.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c883a88 View commit details
    Browse the repository at this point in the history
  17. Fix waiving on new results page

    Include the `WaiveForm` and `ToastAlertGroup` components in the new
    results page so that the waiving UI works as expected.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    bf1b747 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    b3330d7 View commit details
    Browse the repository at this point in the history
  19. Refactor props for simplicity

    Pass the whole `CiTest` to individual results table row components to
    reduce repetition and remove the newly redundant props.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ff58b4c View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    195f989 View commit details
    Browse the repository at this point in the history
  21. Show test dependencies

    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a2696b0 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    8fc1152 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    a5486ec View commit details
    Browse the repository at this point in the history
  24. Reuse existing componets for test suites

    Use already existing components to display test cases within a suite and
    their logs, test phases, etc.
    
    Moreover, do a little refactoring for clarity and composability by
    moving some chunks into names variables or functions.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    e39b419 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    98c72dc View commit details
    Browse the repository at this point in the history
  26. Dispense with a couple of TODOs

    Removed several outdated TODOs and fix those that are easy to fix.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    29e1f9c View commit details
    Browse the repository at this point in the history
  27. Display dynamic title on new results page

    Similar to the old behavior showing the artifact name and gating status,
    if available.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    55b2472 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    1bcb28c View commit details
    Browse the repository at this point in the history
  29. Load contact info for missing tests dynamically

    We know that a test is missing thanks to Greenwave, but we do not have
    any contact-related metadata coming from that channel, so we have to
    pull contact metadata on an as-needed basis if the test is missing.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8b71a51 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    4e99395 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    ef43eff View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    5f888c6 View commit details
    Browse the repository at this point in the history
  33. Fix test selection dataflow

    Make sure to store the requested focus test so that we can look it up
    later, once all the tests have been loaded. This ensures that if you
    select a test and refresh the page, it will expand automatically. This
    was broken previously because the `useEffect()` hook only runs on first
    render and when the query parameters change. When this happens at page
    load, the `tests` variable is not yet populated becuse the query has not
    finished yet. Therefore the correct test could not have been looked up
    at this point in time.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    05a8d64 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    8092cd4 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    dcd9fa5 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    b4147d5 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    df621c6 View commit details
    Browse the repository at this point in the history
  38. Basic search results redesign

    Adjust the search results table according to the UXD mock-up. Use
    a minimalist table with clickable rows that take you to the
    single-artifact view instead of a table with various expandable rows.
    
    Pagination is not yet implemented in this version.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d83d708 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    24f6af6 View commit details
    Browse the repository at this point in the history
  40. Minor refactoring of SearchToolbar

    Clean up code a bit without changing behaviour.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    0598bac View commit details
    Browse the repository at this point in the history
  41. Refactor new artifacts list component

    Refactor the `ArtifactsListNew` component to make it pure and reusable
    across different scenarios. Move the `useQuery()` call out to the parent
    component and insert a business-logic component between the list and
    the `PageByFilters` component.
    mgrabovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    e7920a2 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    912582d View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    6fa2555 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    ac6920e View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    0e0f38e View commit details
    Browse the repository at this point in the history