Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some of the issues in #808 and #810 (score text etc.) #811

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kaorahi
Copy link
Contributor

@kaorahi kaorahi commented Nov 14, 2020

See the commit logs for details.

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Nov 14, 2020
@kaorahi kaorahi mentioned this pull request Nov 14, 2020
@hope366
Copy link

hope366 commented Nov 15, 2020

Fix: score is not shown when the previous move is not evaluated (#810)

Is this PR a fix to improve # 810?
I tried to verify, but when I changed the engine to KataGo after analyzing with LZ, the number on the bar graph and the number in the winning percentage graph are 0 for Score Mean.
What is the specific effect of this PR?

@kaorahi
Copy link
Contributor Author

kaorahi commented Nov 16, 2020

c473734 fixes your "another one" in #810 (comment) . :)

@hope366
Copy link

hope366 commented Nov 16, 2020

I see, it certainly seems to be improving.
It seems that my reading comprehension was a little lacking.
Thank you for creating the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants