Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong score in winrate graph when it is missing #810

Open
kaorahi opened this issue Nov 9, 2020 · 3 comments
Open

Wrong score in winrate graph when it is missing #810

kaorahi opened this issue Nov 9, 2020 · 3 comments

Comments

@kaorahi
Copy link
Contributor

kaorahi commented Nov 9, 2020

  1. Start Leela Zero on Lizzie 0.7.4.
  2. Analyze a game and hit END key.
  3. Switch the engine to KataGo and hit SPACE key to stop pondering.
  4. Hit the up arrow key.

Then we see a wrong score 0.0 in the winrate graph.

In Panel UI, we also get #729 again because I made a wrong fix of the conflict in the merge dc8f872. The line "validScore = " should be placed BEFORE "if (!validWinrate)" in WinratePane.java.

@hope366
Copy link

hope366 commented Nov 9, 2020

Leela Zero doesn't analyze Score Mean, so I think it's natural to show 0.0, but am I doing something wrong?
Also, as I experimented with this issue, I found another one.

  1. After launching lizzie 0.7.4, press the spacebar to turn off pondering.
  2. Next, arrange about 10 stones on the main board.
  3. Press the spacebar to turn on pondering.
  4. Press the up arrow key to return the main board to an empty state.

At this time, stdev and Lastmove are not displayed until the move number becomes 1.
If you turn off pondering and place stones with the down arrow key, they will be displayed, so it seems that the calculation was done internally.

@kaorahi
Copy link
Contributor Author

kaorahi commented Nov 11, 2020

I expect blank when pondering is off and no estimation is available. But 0.0 is displayed actually in my previous post #810 (comment) .

@hope366
Copy link

hope366 commented Nov 11, 2020

After all I seem to have misunderstood a little.
Whether it's LZ or KataGo, if you line up the stones with pondering off, no analysis results will be displayed.
If ScoreMean shows 0 by changing the engine to KataGo after analyzing with LZ, does it mean that there is an instruction to set ScoreMean = 0 at the time of analysis with LZ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants