Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: Allow write winrate etc. to the comment of the sgf by append-winrate-to-comment #379

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

zsalch
Copy link
Contributor

@zsalch zsalch commented Oct 3, 2018

Closes: #308
Base on: #368

Support save the winrate etc. into the comment of Sgf (need turn on "append-winrate-to-comment" in the config.txt)
format as followings:

Move <move number>
<Winrate> (<Last Move Rate Difference>)
(<Weight name> / <Playouts>)

for example:
W[dd]C[Move 2
53.5% (-0.1%)
(elf_v1 / 18k playouts)

other comments];

Copy link
Contributor

@OlivierBlanvillain OlivierBlanvillain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (besides the comment on .get())

@featurecat
Copy link
Owner

I'm merging, because we need to hurry things along for the 0.6 release.

@featurecat featurecat merged commit 73bcc82 into featurecat:next Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants