next: Support Switch Multiple Engine Heights #368
Conversation
| return ""; | ||
| } | ||
| int width = fm.stringWidth(line); | ||
| if (width > fitWidth) { |
There was a problem hiding this comment.
Double space before >
| @@ -80,4 +81,36 @@ public static void saveAsFile(URL url, File file) { | |||
| e.printStackTrace(); | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Fit the too long text by width | |||
There was a problem hiding this comment.
Fit doesn't sound like the correct word here. Maybe crop, cut or truncate?
/** Truncate text that is too long for the given width */| // substitute in the weights file | ||
| engineCommand = engineCommand.replaceAll("%network-file", config.getString("network-file")); | ||
|
|
||
| // Init current engine no and start engine |
There was a problem hiding this comment.
Init current engine number
I would also call the variable differently, currentEngineN or currentEngineNumber.
|
|
||
| public void startEngine(String engineCommand) throws IOException { | ||
| // Check engine command | ||
| if (engineCommand == null || "".equals(engineCommand.trim())) { |
There was a problem hiding this comment.
engineCommand.trim().isEmpty()
| } | ||
| } | ||
| // Go to move number by back routing when in branch | ||
| public boolean goToMoveNumberByBack(int moveNumber) { |
There was a problem hiding this comment.
Why is this a separate method?
There was a problem hiding this comment.
Also the return value is never used, meaning the method can be refactored as follows:
int delta = moveNumber - history.getMoveNumber();
for (int i = 0; i < Math.abs(delta); i++) {
BoardHistoryNode curNode = history.getCurrentHistoryNode();
if (curNode.numberOfChildren() > 1 && delta > 0) {
nextMove(curNode.getFromBackChildren());
} else {
if (!(delta > 0 ? nextMove() : previousMove())) {
return;
}
}
}There was a problem hiding this comment.
The function goToMoveNumberByBack process the move by saved the children branch.
There was a problem hiding this comment.
Return value removed.
| } | ||
| } | ||
| // Save the move number | ||
| public BoardHistoryNode saveMoveNumber() { |
There was a problem hiding this comment.
The returned value is never used.
| @@ -433,6 +435,79 @@ public boolean nextMove() { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Goes to the next coordinate, thread safe | |||
There was a problem hiding this comment.
The documentation doesn't explain the meaning of the returned boolean.
| saveNode = curNode; | ||
| return curNode; | ||
| } | ||
| // Save the back routing |
There was a problem hiding this comment.
In general, I would avoid comments that paraphrase method name: they don't add any information to what the code already says.
| node.previous().setFromBackChildren(node.previous().getNexts().indexOf(node)); | ||
| saveBackRouting(node.previous()); | ||
| } | ||
| return; |
|
@OlivierBlanvillain |
| @@ -80,4 +81,37 @@ public static void saveAsFile(URL url, File file) { | |||
| e.printStackTrace(); | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
|
Needs a rebased, LGTM otherwise! |
|
I took care of the conflicts, let's get this in 🎉 |
Closes: #356
Support to switching multiple engine heights. (Currently only support Leela Zero Engine)
How to config:
"engine-command": "./leelaz --gtp --lagbuffer 0 --weights %network-file --threads 2",
"engine-command-list": [
"./leelaz --gtp --lagbuffer 0 --weights leelaz_172_b1c --threads 2",
"./leelaz --gtp --lagbuffer 0 --weights human_best --threads 2",
"./leelaz --gtp --lagbuffer 0 --weights elf_1_62b --threads 2",
"./leelaz --gtp --lagbuffer 0 --weights leelaz_157_d35 --threads 2"
],
Ctrl+0: Default switch to "engine-command"
Ctrl+(1-9): Switch to "engine-command-list"
Demo:
