This repository has been archived by the owner on Aug 6, 2023. It is now read-only.
Add bounds check when drawing line high/low #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extrawurst
reviewed
May 6, 2020
|
Thanks for reporting the issue. The fix makes sense but could you also add a test to cover this edge case ? |
|
Totally! I'm honestly not certain how to exactly hit the erroneous codepath, but I added a test that recreates the conditions I got the crash. If there's a better way to trigger the error, I can revise :) |
24seconds
pushed a commit
to 24seconds/tui-rs
that referenced
this pull request
Nov 30, 2020
…hau#283) * Add bounds check when drawing line high/low * Add test to ensure codepath doesn't break
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for underflow bug when using line generation: #280