-
Notifications
You must be signed in to change notification settings - Fork 487
docs: Fix missing code block fence for hidden_legend_constraints #274
Conversation
EDIT: This was originally just a documentation fix but I found the |
I think that your fix is the object of an other dedicated PR (#283). So I would happily take the documentation fix in this PR and resolve the overflow bug in the other one. |
Ah, my bad. Forgot that I pushed that change temporarily to use in my Cargo. I'll revert the third commit. The second commit is different from that PR; this is more of a fix for if I can revert that commit as well and do it in a separate PR if that's better. |
…for lines" This reverts commit 2be5ddd.
Thanks. No you can left the other bug fix here that's fine. I've left a comment and it would be nice if you could add a small test covering this case as well. |
Thanks ! |
* docs: Fix missing code block fence * use slice::windows to deal with underflow issue * add test for empty dataset and lines
Two things:
GraphType::Line
, if the dataset is empty, you can end up with a subtraction underflow when you do the length - 1.