-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disabled aiokafka unit tests #610
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
bd934d9
mess around this unit tests for aiokafka statuses
wbarnha 75e8f87
apparently highwater had a bug???
wbarnha 492ea2e
fix formatting
wbarnha 4f1323b
wow has this been broken this entire time???
wbarnha ce00568
fix more tests
wbarnha cb6f4ef
lint
wbarnha a7cea11
fix yet another test
wbarnha 56cad2b
fix yet another test
wbarnha ea02c21
remove unneeded import
wbarnha 0554b00
re-enable another test
wbarnha d09a889
fix linting
wbarnha f1d6534
fix another test
wbarnha 2b73255
Merge branch 'master' into fix-aiokafka-unittests
wbarnha 9c17a17
Update aiokafka.py
wbarnha d58a171
Merge branch 'master' into fix-aiokafka-unittests
wbarnha 32e7a51
revert changes
wbarnha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -840,14 +840,14 @@ def _verify_aiokafka_event_path(self, now: float, tp: TP) -> bool: | |
poll_at = None | ||
aiotp_state = assignment.state_value(aiotp) | ||
if aiotp_state and aiotp_state.timestamp: | ||
poll_at = aiotp_state.timestamp / 1000 | ||
poll_at = aiotp_state.timestamp | ||
if poll_at is None: | ||
if secs_since_started >= self.tp_fetch_request_timeout_secs: | ||
# NO FETCH REQUEST SENT AT ALL SINCE WORKER START | ||
self.log.error( | ||
SLOW_PROCESSING_NO_FETCH_SINCE_START, | ||
tp, | ||
secs_since_started, | ||
humanize_seconds_ago(secs_since_started), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Accidentally reverted this in |
||
) | ||
return True | ||
|
||
|
@@ -857,7 +857,7 @@ def _verify_aiokafka_event_path(self, now: float, tp: TP) -> bool: | |
self.log.error( | ||
SLOW_PROCESSING_NO_RECENT_FETCH, | ||
tp, | ||
secs_since_request, | ||
humanize_seconds_ago(secs_since_request), | ||
) | ||
return True | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this change was originally implemented in dcc421f by @patkivikram, could you expand on this?