Fix disabled aiokafka unit tests #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #610 +/- ##
==========================================
+ Coverage 93.69% 94.08% +0.38%
==========================================
Files 102 102
Lines 11117 11117
Branches 1550 1550
==========================================
+ Hits 10416 10459 +43
+ Misses 609 558 -51
- Partials 92 100 +8 ☔ View full report in Codecov by Sentry. |
wbarnha
commented
Apr 1, 2024
| @@ -840,14 +840,14 @@ def _verify_aiokafka_event_path(self, now: float, tp: TP) -> bool: | |||
| poll_at = None | |||
| aiotp_state = assignment.state_value(aiotp) | |||
| if aiotp_state and aiotp_state.timestamp: | |||
| poll_at = aiotp_state.timestamp / 1000 | |||
There was a problem hiding this comment.
Looks like this change was originally implemented in dcc421f by @patkivikram, could you expand on this?
wbarnha
commented
Apr 1, 2024
| if poll_at is None: | ||
| if secs_since_started >= self.tp_fetch_request_timeout_secs: | ||
| # NO FETCH REQUEST SENT AT ALL SINCE WORKER START | ||
| self.log.error( | ||
| SLOW_PROCESSING_NO_FETCH_SINCE_START, | ||
| tp, | ||
| secs_since_started, | ||
| humanize_seconds_ago(secs_since_started), |
There was a problem hiding this comment.
Accidentally reverted this in master, ignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's going to be hard to investigate what's going on with #175 unless we get better testing in place.