Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better prefill and completion for :GoRename #1465

Merged
merged 3 commits into from
Oct 14, 2017
Merged

Better prefill and completion for :GoRename #1465

merged 3 commits into from
Oct 14, 2017

Commits on Oct 14, 2017

  1. Better prefill and completion for :GoRename 

    1. Repurpose `g:go_gorename_prefill` to be an expression, which can
   transform the value that is pre-filled to the most common forms.
   The default is to use camelCase when the identifiers starts with a
   lowercase letter, and CamelCase when it starts with an uppercase
   letter, which sounds like a reasonable guess to me.
2. Add completion support, so you can use `:GoRename <Tab>` to get the
   most common options.

Both of these changes make it a bit easier/faster to use, especially if
you need to rename a bunch of identifiers in a project that doesn't
follow Go standards (like I had to do last week).
    @arp242
    arp242 committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    172139c View commit details
    Browse the repository at this point in the history

  2. Address PR feedback 

    - Rename `camelcaseExported` to `pascalcase`.
- `g:go_gorename_prefill=1` is an alias for the default, for
  compatibility reasons.
    @arp242
    arp242 committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    d3a07e2 View commit details
    Browse the repository at this point in the history

  3. Also clarify docs a bit

    @arp242
    arp242 committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    57d60ff View commit details
    Browse the repository at this point in the history