test: full code coverage (#77) #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Aug 5, 2020
index.js
Outdated
| @@ -173,3 +173,5 @@ module.exports = fp(fastifyCors, { | |||
| fastify: '3.x', | |||
| name: 'fastify-cors' | |||
| }) | |||
|
|
|||
| module.exports.vary = vary | |||
There was a problem hiding this comment.
Can you move vary to its own file so you can test it separately without exposing it to the public?
There was a problem hiding this comment.
Is there a reason why we can't use the vary function of the vary module?
There was a problem hiding this comment.
that works with node core ServerResponse object.
There was a problem hiding this comment.
Do you think I should add more tests for the vary function itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkNOTE:
Please consider I needed to esport the
varyfunction in order to test theelsepath which is never taken otherwise.It is just a way but I'm open to suggestions off course.