Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100% code coverage #77

Closed
mcollina opened this issue Jul 19, 2020 · 5 comments
Closed

100% code coverage #77

mcollina opened this issue Jul 19, 2020 · 5 comments
Labels
good first issue Good for newcomers

Comments

@mcollina
Copy link
Member

As titled!

----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |    88.41 |    80.65 |      100 |    88.89 |                   |
 index.js |    88.41 |    80.65 |      100 |    88.89 |... 43,146,148,150 |
----------|----------|----------|----------|----------|-------------------|
@mcollina mcollina added the good first issue Good for newcomers label Jul 19, 2020
@alemagio
Copy link
Contributor

alemagio commented Aug 1, 2020

On it.

alemagio added a commit to alemagio/fastify-cors that referenced this issue Aug 1, 2020
@alemagio
test: test for access-control-request-headers scenario (fastify#77)
8e43498
@alemagio
Copy link
Contributor

alemagio commented Aug 1, 2020

Not 100% yet but it's something 😅

mcollina pushed a commit that referenced this issue Aug 1, 2020
@alemagio
test: test for access-control-request-headers scenario (#77) (#80)
a479093
alemagio added a commit to alemagio/fastify-cors that referenced this issue Aug 5, 2020
@alemagio
test: test for array and regex origin options (fastify#77)
d79926b
@alemagio
Copy link
Contributor

alemagio commented Aug 5, 2020

With this one we should be 100% covered.

mcollina pushed a commit that referenced this issue Aug 5, 2020
@alemagio
test: test for array and regex origin options (#77) (#81)
129e98f
alemagio added a commit to alemagio/fastify-cors that referenced this issue Aug 5, 2020
@alemagio
test: full code coverage (fastify#77)
dd09bc9
alemagio added a commit to alemagio/fastify-cors that referenced this issue Aug 5, 2020
@alemagio
test: full code coverage (fastify#77)
5c422b7
@alemagio
Copy link
Contributor

alemagio commented Aug 5, 2020

Now for real 😅

alemagio added a commit to alemagio/fastify-cors that referenced this issue Aug 5, 2020
@alemagio
test: moved vary to its own module (fastify#77)
4db355d
mcollina pushed a commit that referenced this issue Aug 5, 2020
@alemagio
test: full code coverage (#77) (#82)
67f0007 
* test: full code coverage (#77)

* test: moved vary to its own module (#77)

* test: added vary module
@zekth
Copy link
Member

zekth commented Aug 8, 2020

I think this issue can be closed:

Suites:   2 passed, 2 of 2 completed
Asserts:  121 passed, of 121
Time:     1s
----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |      100 |      100 |      100 |      100 |                   |
 index.js |      100 |      100 |      100 |      100 |                   |
 vary.js  |      100 |      100 |      100 |      100 |                   |
----------|----------|----------|----------|----------|-------------------|

@mcollina mcollina closed this as completed Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcollina @zekth @alemagio