feat: alt way for auth media (BREAKING) #1903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
td-famedly
force-pushed
the
td/altAuthMedia
branch
from
1c0e1f5
to
17840b2
Compare
nico-famedly
approved these changes
Aug 16, 2024
krille-chan
reviewed
Aug 16, 2024
|
|
||
| try { | ||
| return request('_matrix/client/v1/media/config'); | ||
| } catch (e) { |
There was a problem hiding this comment.
Do we know the exact error message that would be returned here? Then we should listen to only this and rethrow other errors
krille-chan
reviewed
Aug 16, 2024
| try { | ||
| return request( | ||
| '_matrix/client/v1/media/download/${Uri.encodeComponent(serverName)}/${Uri.encodeComponent(mediaId)}'); | ||
| } catch (e) { |
krille-chan
reviewed
Aug 16, 2024
| try { | ||
| return request( | ||
| '_matrix/client/v1/media/download/${Uri.encodeComponent(serverName)}/${Uri.encodeComponent(mediaId)}/${Uri.encodeComponent(fileName)}'); | ||
| } catch (e) { |
krille-chan
reviewed
Aug 16, 2024
|
|
||
| try { | ||
| return request('_matrix/client/v1/media/preview_url'); | ||
| } catch (e) { |
krille-chan
requested changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the version checks, and expects clients to manually return both endpoints using the
useAuthenticationflagBreaking change but tries both new and old endpoints. Would require clients to implement a retry mech for their media if they fail.
Particularly useful when servers are misconfigured so they return on the old endpoints but not on the new ones. (not a fan, just configure them correctly!)