Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for authenticated media #1901

Merged
merged 1 commit into from
Aug 16, 2024
Merged

feat: support for authenticated media #1901

merged 1 commit into from
Aug 16, 2024

Conversation

td-famedly
Copy link
Member

@td-famedly td-famedly commented Aug 15, 2024

The ideal way to fix this would be autogen with the v1.11 spec. But because it changed from openapi v2 to v3 that looks like a bit more work than expected. Separating out auth media stuff from that because of urgency.

To test these changes please make sure your server properly registers the new media endpoints. Famedly servers do not atm because of worker misconfiguration. Tracking issue: https://github.com/famedly/infra-meta/issues/1688

@td-famedly td-famedly requested a review from a team as a code owner August 15, 2024 07:47
@td-famedly td-famedly force-pushed the td/authMedia branch 2 times, most recently from f14e615 to 9828f5c Compare August 16, 2024 07:41
lib/src/client.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@krille-chan krille-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making the getDownloadLink and getThumbnail methods async seems to be okay. I checked it in FluffyChat and there it always looks like it is not that big of a deal to use it this way. So we can be sure we always have the correct link. Thank you very much

lib/src/client.dart Outdated Show resolved Hide resolved
@td-famedly td-famedly merged commit 6bf03a8 into main Aug 16, 2024
12 checks passed
@td-famedly td-famedly deleted the td/authMedia branch August 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants