refactor: BREAKING Add new authenticated media endpoints #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krille-chan
force-pushed
the
krille/migrate-download-media-links
branch
from
b8648dd
to
de91009
Compare
td-famedly
reviewed
Jul 29, 2024
| ); | ||
| } | ||
|
|
||
| @Deprecated('Use `getAuthenticatedDownloadLink()` instead') |
There was a problem hiding this comment.
Are these deprecated? The guide asks you to check the server supported version and then use the the endpoint corresponding to the supported version
If the server doesn’t support Matrix 1.11, the existing /_matrix/media/* endpoints should continue to be used.
| @@ -1310,8 +1310,8 @@ void main() { | |||
| final THUMBNAIL_BUFF = Uint8List.fromList([2]); | |||
| Future<Uint8List> downloadCallback(Uri uri) async { | |||
| return { | |||
| '/_matrix/media/v3/download/example.org/file': FILE_BUFF, | |||
| '/_matrix/media/v3/download/example.org/thumb': THUMBNAIL_BUFF, | |||
| '/_matrix/client/v1/media/download/example.org/file': FILE_BUFF, | |||
There was a problem hiding this comment.
can we have the old ones and also add the new endpoints to make sure both are supported as expected?
|
superseeded by #1901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/famedly/product-management/issues/2026