Deprecate FillMurray service #2657
Conversation
There was a problem hiding this comment.
hi @ferblape Thank you for your contribution!
My only concern here is that since our generator only returns the URL, users might not be aware of this service not generating URLS that can be accessed. So if we just remove this generator without any warnings, it could break someone's code that is expecting a URL.
So, I would like to avoid removing features without deprecating them first. There is a section about it on our CONTRIBUTING guide. Thank you!
|
I agree with Stefanni, we should probably deprecate this module (including a deprecation warning whenever it's used) and then remove the module in Faker 4 |
ferblape
force-pushed
the
remove-fill-murray
branch
from
166ab81
to
e4b8f4a
Compare
|
Hi @stefannibrasil my apologies for not having reviewed first other PRs or reviewed the contribution guides. The PR has been updated and now the module is deprecated. |
There was a problem hiding this comment.
hi @ferblape thank you for your patience as I get back from my break. No worries about the deprecation. Do you have any suggestions for helping contributors finding the guidelines easier?
I left some comments. Thank you!
There was a problem hiding this comment.
Thank you @ferblape ! Are you okay with opening a new PR to remove it next month? 👍
|
hi @ferblape this PR was merged and was included in the latest release. Are you still interested in opening a new PR to remove it? Thanks! |
|
Of course, I've just created the PR. Hope you find it easier to review than this one 👯 |
Summary
This PR deprecates FillMurray service, the service is not responding and given it's an Heroku app it might be a free tier that won't work again.
Other Information
Nop