Deprecate Fillmurray service

faker-ruby · Dec 28, 2022 · e4b8f4a · e4b8f4a
1 parent 4367d4e
commit e4b8f4a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/faker/default/fillmurray.rb b/lib/faker/default/fillmurray.rb
@@ -24,13 +24,15 @@ class << self
       #     #=> "https://fillmurray.com/200/400"
       #
       # @faker.version 1.7.1
+      extend Gem::Deprecate
       def image(grayscale: false, width: 200, height: 200)
         raise ArgumentError, 'Width should be a number' unless width.to_s =~ /^\d+$/
         raise ArgumentError, 'Height should be a number' unless height.to_s =~ /^\d+$/
         raise ArgumentError, 'Grayscale should be a boolean' unless [true, false].include?(grayscale)
 
         "https://www.fillmurray.com#{'/g' if grayscale == true}/#{width}/#{height}"
       end
+      deprecate :image, 'Faker::LoremFlickr.image', 2022, 12
     end
   end
 end
diff --git a/test/faker/default/test_faker_fillmurray.rb b/test/faker/default/test_faker_fillmurray.rb
@@ -11,6 +11,14 @@ def test_fillmurray
     refute_nil @tester.image(grayscale: false, width: '300', height: '300').match(%r{https://www\.fillmurray\.com/(\d+)/(\d+)})
   end
 
+  def test_image_deprecation_message
+    _out, err = capture_output do
+      @tester.image(grayscale: false, width: '300', height: '300')
+    end
+
+    assert_match(/Faker::Fillmurray.image is deprecated; use Faker::LoremFlickr.image instead\./, err)
+  end
+
   def test_fillmurray_with_grayscale
     assert_equal('g/', @tester.image(grayscale: true, width: '300', height: '300').match(%r{https://www\.fillmurray\.com/(g?/?)(\d+)/(\d+)})[1])
   end