Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2309] Fixed error for random in markdown #2443

Merged
merged 1 commit into from
Mar 10, 2022
Merged

[2309] Fixed error for random in markdown #2443

merged 1 commit into from
Mar 10, 2022

Conversation

sudeeptarlekar
Copy link
Contributor

@sudeeptarlekar sudeeptarlekar commented Jan 12, 2022 •
edited
Loading

Signed-off-by: sudeeptarlekar sudeeptarlekar@gmail.com

Issue#

closes #2309

Description:

  1. Fixed error in markdown config

@sudeeptarlekar sudeeptarlekar changed the title [2309] Fixed error for random in markdown [WIP][2309] Fixed error for random in markdown Jan 12, 2022
@sudeeptarlekar
[2309] Fixed error for random in markdown
d00e83f 
Signed-off-by: sudeeptarlekar <sudeeptarlekar@gmail.com>
@sudeeptarlekar sudeeptarlekar changed the title [WIP][2309] Fixed error for random in markdown [2309] Fixed error for random in markdown Mar 10, 2022
@sudeeptarlekar
Copy link
Contributor Author

sudeeptarlekar commented Mar 10, 2022 •
edited
Loading

There was issue in Random in truffleruby, specs are now passing successfully.

@vbrazo, @psibi, @koic can someone pls review this?

@koic koic merged commit e4a90c3 into faker-ruby:master Mar 10, 2022
@koic
Copy link
Member

koic commented Mar 10, 2022

Thanks!

@sudeeptarlekar sudeeptarlekar deleted the 2309-truffleruby-errors branch December 1, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Actions] TruffleRuby checks fails silently
2 participants
@sudeeptarlekar @koic