Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actions] TruffleRuby checks fails silently #2309

Closed
meuble opened this issue Apr 26, 2021 · 1 comment · Fixed by #2443
Closed

[Actions] TruffleRuby checks fails silently #2309

meuble opened this issue Apr 26, 2021 · 1 comment · Fixed by #2443

Comments

@meuble
Copy link
Contributor

meuble commented Apr 26, 2021

Description

TruffleRuby fails to run the tests without errors, but this doesn't prevent the CI to raise any warning.

To Reproduce

Run the tests on TruffleRuby.

Expected behavior

I would expect that if some of the tests doesn't succeed, the CI should prevent the PR to be accepted and should display warnings.

I would also expect the tests to fully succeed and TruffelRuby.

Additional context

See the following PR for example (one accepted, on pending — currently at least):

@sudeeptarlekar
Copy link
Contributor

Found something happening differently in truffleruby for source method. Created issue for same.
oracle/truffleruby#2569

Meanwhile adding quick patch for same and raising a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants