Rename tests according to the test*.rb pattern so that they run #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeragamba
approved these changes
Jul 8, 2020
gabrielbaldao
pushed a commit
to gabrielbaldao/faker
that referenced
this pull request
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
No-StoryTechnically. However, it's related to issue #2076. I saw that PR #2071 addressed the issue but added or changed no tests. I was wondering why the 2.13.0 update didn't break any tests if it broke functionality, and discovered it was a naming issue.
Description:
The tests in
test/faker/blockchain/never ran.rakewill, as pertasks/test.rake, only run test files which matchFileList['test/**/**/test*.rb']. This file was last changed on Nov 11 2018 by d574bd9, and the tests in theblockchainfolder all added afterwards.This PR:
test_test_blockin the newtest_tezos.rbwhich was callingFaker::Tezosinstead ofFaker::Blockchain::TezosTesting output changed from
1537 tests, 81356 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notificationsto
1551 tests, 81369 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications