Fix regression in Faker::Base58.encode (works in 2.12.0, breaks in 2.13.0) #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faker-ruby@0216e7d fixed the rubocop offense in a wrong way — it should've migrated to .unpack1 instead. https://docs.rubocop.org/rubocop/0.85/cops_style.html#styleunpackfirst This in turn breaks e.g. generation of bitcoin addresses: irb(main):001:0> require 'faker' => true irb(main):002:0> Faker::Blockchain::Bitcoin.address Traceback (most recent call last): 11: from /Users/vesa/.rbenv/versions/2.6.5/bin/irb:23:in `<main>' 10: from /Users/vesa/.rbenv/versions/2.6.5/bin/irb:23:in `load' 9: from /Users/vesa/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/irb-1.0.0/exe/irb:11:in `<top (required)>' 8: from (irb):2 7: from /Users/vesa/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/faker-2.13.0/lib/faker/blockchain/bitcoin.rb:27:in `address' 6: from /Users/vesa/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/faker-2.13.0/lib/faker/blockchain/bitcoin.rb:55:in `address_for' 5: from /Users/vesa/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/faker-2.13.0/lib/helpers/base58.rb:10:in `encode' 4: from /Users/vesa/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/faker-2.13.0/lib/helpers/base58.rb:10:in `each_with_index' 3: from /Users/vesa/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/faker-2.13.0/lib/helpers/base58.rb:10:in `each' 2: from /Users/vesa/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/faker-2.13.0/lib/helpers/base58.rb:10:in `block in encode' 1: from /Users/vesa/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/faker-2.13.0/lib/helpers/base58.rb:10:in `+' TypeError (Array can't be coerced into Integer)
koic
approved these changes
Jul 1, 2020
|
Nice 👍 |
This was referenced Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
No-StoryDescription:
0216e7d from #2038 fixed the rubocop offense in a wrong way — it should've migrated to .unpack1 instead.
https://docs.rubocop.org/rubocop/0.85/cops_style.html#styleunpackfirst
This in turn breaks e.g. generation of bitcoin addresses:
This used to work in Faker 2.12.0 but got broken in 2.13.0.