Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix another ambiguity in element_symbol field #1743

Merged
merged 1 commit into from
Sep 14, 2019
Merged

Fix another ambiguity in element_symbol field #1743

merged 1 commit into from
Sep 14, 2019

Commits on Sep 14, 2019

  1. Fix another ambiguity in element_symbol field 

    The Yaml specification treats both Y and No as boolean:
https://yaml.org/type/bool.html

This causes problem when parsing them as a string. The patch makes
sure that the Yaml parser treats them as string.

This should have been fixed as part of
faker-ruby#1717 but I missed it somehow.
    @psibi
    psibi committed Sep 14, 2019
    Configuration menu
    Copy the full SHA
    f22d026 View commit details
    Browse the repository at this point in the history