Fix ambiguity in element_symbol field #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Yaml specification treats both `Y` and `No` as boolean: https://yaml.org/type/bool.html This causes problem when parsing them as a string. The patch makes sure that the Yaml parser treats them as string. Background: Found this bug while writing some test code for [fakedata](https://github.com/psibi/fakedata) which uses this project's data source.
|
@vbrazo I see that you have assigned the PR to me. Is there anything else pending ? The other locales doesn't need to be updated as |
psibi
added a commit
to psibi/faker
that referenced
this pull request
Sep 14, 2019
The Yaml specification treats both Y and No as boolean: https://yaml.org/type/bool.html This causes problem when parsing them as a string. The patch makes sure that the Yaml parser treats them as string. This should have been fixed as part of faker-ruby#1717 but I missed it somehow.
vbrazo
pushed a commit
that referenced
this pull request
Sep 14, 2019
The Yaml specification treats both Y and No as boolean: https://yaml.org/type/bool.html This causes problem when parsing them as a string. The patch makes sure that the Yaml parser treats them as string. This should have been fixed as part of #1717 but I missed it somehow.
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
The Yaml specification treats both `Y` and `No` as boolean: https://yaml.org/type/bool.html This causes problem when parsing them as a string. The patch makes sure that the Yaml parser treats them as string. Background: Found this bug while writing some test code for [fakedata](https://github.com/psibi/fakedata) which uses this project's data source.
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
The Yaml specification treats both Y and No as boolean: https://yaml.org/type/bool.html This causes problem when parsing them as a string. The patch makes sure that the Yaml parser treats them as string. This should have been fixed as part of faker-ruby#1717 but I missed it somehow.
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
The Yaml specification treats both `Y` and `No` as boolean: https://yaml.org/type/bool.html This causes problem when parsing them as a string. The patch makes sure that the Yaml parser treats them as string. Background: Found this bug while writing some test code for [fakedata](https://github.com/psibi/fakedata) which uses this project's data source.
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
The Yaml specification treats both Y and No as boolean: https://yaml.org/type/bool.html This causes problem when parsing them as a string. The patch makes sure that the Yaml parser treats them as string. This should have been fixed as part of faker-ruby#1717 but I missed it somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Yaml specification treats both
YandNoas boolean:https://yaml.org/type/bool.html
This causes problem when parsing them as a string. The patch makes
sure that the Yaml parser treats them as string.
Background: Found this bug while writing some test code for
fakedata which uses this project's data source.