Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image): dataUri should return random type #3347

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

matthewmayer
Copy link
Contributor

fix #3346

arrayElements() was used by mistake instead of arrayElement()

@matthewmayer matthewmayer requested a review from a team as a code owner December 28, 2024 17:58
Copy link

netlify bot commented Dec 28, 2024

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2186015
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/677047a2715802000899dc91
😎 Deploy Preview https://deploy-preview-3347.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewmayer matthewmayer self-assigned this Dec 28, 2024
@matthewmayer matthewmayer added c: bug Something isn't working p: 1-normal Nothing urgent m: image Something is referring to the image module labels Dec 28, 2024
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (e6d27a3) to head (2186015).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3347      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2811     2811              
  Lines      217017   217017              
  Branches      941      939       -2     
==========================================
- Hits       216966   216964       -2     
- Misses         51       53       +2     
Files with missing lines Coverage Δ
src/modules/image/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT added this to the vAnytime milestone Dec 28, 2024
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why TS didn't warn here.

@ST-DDT ST-DDT requested review from a team December 28, 2024 18:56
@ST-DDT ST-DDT added this pull request to the merge queue Dec 29, 2024
Merged via the queue into faker-js:next with commit eceb17d Dec 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working m: image Something is referring to the image module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

faker.image.dataUri() always returns svg-base64
2 participants