Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faker.image.dataUri() always returns svg-base64 #3346

Closed
matthewmayer opened this issue Dec 28, 2024 · 0 comments · Fixed by #3347
Closed

faker.image.dataUri() always returns svg-base64 #3346

matthewmayer opened this issue Dec 28, 2024 · 0 comments · Fixed by #3347
Assignees
@matthewmayer
Labels
c: bug Something isn't working m: image Something is referring to the image module p: 1-normal Nothing urgent
Milestone
vAnytime

Comments

@matthewmayer
Copy link
Contributor

faker.image.dataUri() should return either of the 'svg-uri', 'svg-base64' types if no type if provided, but actually always returns 'svg-base64'

> faker.image.dataUri()
'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSIzNjI2IiBoZWlnaHQ9IjM3NDUiPjxyZWN0IHdpZHRoPSIxMDAlIiBoZWlnaHQ9IjEwMCUiIGZpbGw9IiM4ZTk3ZTgiLz48dGV4dCB4PSIxODEzIiB5PSIxODcyLjUiIGZvbnQtc2l6ZT0iMjAiIGFsaWdubWVudC1iYXNlbGluZT0ibWlkZGxlIiB0ZXh0LWFuY2hvcj0ibWlkZGxlIiBmaWxsPSJ3aGl0ZSI+MzYyNngzNzQ1PC90ZXh0Pjwvc3ZnPg=='
> faker.image.dataUri()
'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSIxOTI2IiBoZWlnaHQ9IjI2MjgiPjxyZWN0IHdpZHRoPSIxMDAlIiBoZWlnaHQ9IjEwMCUiIGZpbGw9IiNhNTc3ZDMiLz48dGV4dCB4PSI5NjMiIHk9IjEzMTQiIGZvbnQtc2l6ZT0iMjAiIGFsaWdubWVudC1iYXNlbGluZT0ibWlkZGxlIiB0ZXh0LWFuY2hvcj0ibWlkZGxlIiBmaWxsPSJ3aGl0ZSI+MTkyNngyNjI4PC90ZXh0Pjwvc3ZnPg=='
> faker.image.dataUri()
'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSIyMzc4IiBoZWlnaHQ9IjExNDAiPjxyZWN0IHdpZHRoPSIxMDAlIiBoZWlnaHQ9IjEwMCUiIGZpbGw9IiNlZGMzY2EiLz48dGV4dCB4PSIxMTg5IiB5PSI1NzAiIGZvbnQtc2l6ZT0iMjAiIGFsaWdubWVudC1iYXNlbGluZT0ibWlkZGxlIiB0ZXh0LWFuY2hvcj0ibWlkZGxlIiBmaWxsPSJ3aGl0ZSI+MjM3OHgxMTQwPC90ZXh0Pjwvc3ZnPg=='
> faker.image.dataUri()
'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSI2MjUiIGhlaWdodD0iMjA3NiI+PHJlY3Qgd2lkdGg9IjEwMCUiIGhlaWdodD0iMTAwJSIgZmlsbD0iIzBhNzhhYiIvPjx0ZXh0IHg9IjMxMi41IiB5PSIxMDM4IiBmb250LXNpemU9IjIwIiBhbGlnbm1lbnQtYmFzZWxpbmU9Im1pZGRsZSIgdGV4dC1hbmNob3I9Im1pZGRsZSIgZmlsbD0id2hpdGUiPjYyNXgyMDc2PC90ZXh0Pjwvc3ZnPg=='
> faker.image.dataUri()
'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9ImZ1bGwiIHdpZHRoPSIxMjMyIiBoZWlnaHQ9IjEzNDAiPjxyZWN0IHdpZHRoPSIxMDAlIiBoZWlnaHQ9IjEwMCUiIGZpbGw9IiMzNmE2OGMiLz48dGV4dCB4PSI2MTYiIHk9IjY3MCIgZm9udC1zaXplPSIyMCIgYWxpZ25tZW50LWJhc2VsaW5lPSJtaWRkbGUiIHRleHQtYW5jaG9yPSJtaWRkbGUiIGZpbGw9IndoaXRlIj4xMjMyeDEzNDA8L3RleHQ+PC9zdmc+'
@matthewmayer matthewmayer self-assigned this Dec 28, 2024
@matthewmayer matthewmayer added c: bug Something isn't working p: 1-normal Nothing urgent m: image Something is referring to the image module labels Dec 28, 2024
@matthewmayer matthewmayer mentioned this issue Dec 28, 2024
Merged
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewmayer matthewmayer

Labels
c: bug Something isn't working m: image Something is referring to the image module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging a pull request may close this issue.

fix(image): dataUri should return random type matthewmayer/faker
2 participants
@matthewmayer @ST-DDT