This repository has been archived by the owner on May 6, 2024. It is now read-only.
Add nle_settings to nledl interface, don't use environment variables #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 30, 2021 12:26
Testing this has revealed a longstanding issue via test_system.py when run in debug mode.
facebook-github-bot
added
the
CLA Signed
And while we are at it, let's not actually write to disk for this one either. This allows us to remove _set_env_vars() from nethack.py.
heiner
force-pushed
the
heiner/nledl-interface
branch
from
c9b7e63 to
dab0d23
Compare
samvelyan
approved these changes
Nov 30, 2021
cdmatters
approved these changes
Dec 10, 2021
| */ | ||
| char hackdir[4096]; | ||
| char options[32768]; | ||
| char wizkit[4096]; |
There was a problem hiding this comment.
just saw that below we always set to "ansi" in get env. is it worth including it here instead?
There was a problem hiding this comment.
We kind of require "ansi" as the value ever since dropping the dependency on ncurses, so any other user-supplied value would break it I think.
| : dlpath_(std::move(dlpath)), obs_{}, spawn_monsters_(spawn_monsters) | ||
| { | ||
| if (hackdir.size() > sizeof(settings_.hackdir) - 1) { | ||
| throw std::length_error("hackdir too long"); | ||
| } | ||
| if (nethackoptions.size() > sizeof(settings_.options)) { |
There was a problem hiding this comment.
is one of these off by one?
There was a problem hiding this comment.
Good question. The reason for the difference is that in nle.c we need to add a / at the end. This is perhaps a bit unclean, but reflects what NetHack itself does in a comparable situation.
There was a problem hiding this comment.
But that / only needs to be added to HACKDIR.
| void | ||
| set_wizkit(std::string wizkit) | ||
| { | ||
| if (wizkit.size() > sizeof(settings_.wizkit)) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also gets rid of the need to write a file for WIZKIT.
Fixes the race condition in #287