Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Race condition in environment settings #287

Closed
heiner opened this issue Nov 24, 2021 · 1 comment
Closed

Race condition in environment settings #287

heiner opened this issue Nov 24, 2021 · 1 comment

Comments

@heiner
Copy link
Contributor

heiner commented Nov 24, 2021

🐛 Bug

Currently, we set environment variables before init and before reset. In the case of HACKDIR, this is problematic as there's a race when several instances of NLE get reset or initialized simultaneously.

On top of that, using environment variables is a bit ugly in our case.

We should create an nle_settings struct that contains these and funnel them through.
@heiner heiner mentioned this issue Nov 30, 2021
Merged
@heiner
Copy link
Contributor Author

heiner commented Jan 20, 2022

Fixed in #291.

@heiner heiner closed this as completed Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@heiner