Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc update sprint 3 #977

Merged
merged 11 commits into from
Jan 31, 2025
Merged

Conversation

zyaoj
Copy link
Contributor

@zyaoj zyaoj commented Jan 16, 2025

What does this PR do? Please describe:

  • correct data loader according to our examples
  • add Jupyter notebook examples on data & data pipeline (add also nbsphinx)
  • add to the tutorial a small note about the eos token (attention)
  • fix typo in (basename “$CKPT_DIR”) (fix Quick start and Getting started documentation issue #964)
  • add a small dpo training example in the end2end fine-tuning
  • add setup w/ uv
  • update logo to svg (can fix some lfs errors)

Does your PR introduce any breaking changes? If yes, please list them:
N/A

Check list:

  • Was the content of this PR discussed and approved via a GitHub issue? (no need for typos or documentation improvements)
  • Did you read the contributor guideline?
  • Did you make sure that your PR does only one thing instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (no need for typos, documentation, or minor internal changes)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025
@zyaoj zyaoj changed the title Zyaoj/doc update sprint 3 doc update sprint 3 Jan 16, 2025
@zyaoj zyaoj marked this pull request as ready for review January 17, 2025 15:48
@zyaoj zyaoj requested a review from cbalioglu as a code owner January 17, 2025 15:48
@zyaoj zyaoj requested a review from uralik January 17, 2025 15:48
@zyaoj zyaoj self-assigned this Jan 17, 2025
@zyaoj zyaoj mentioned this pull request Jan 21, 2025
7 tasks
@zyaoj zyaoj changed the base branch from main to zyaoj/doc-update-sprint-4 January 31, 2025 10:00
@zyaoj zyaoj merged commit 96ff668 into zyaoj/doc-update-sprint-4 Jan 31, 2025
7 checks passed
@zyaoj zyaoj deleted the zyaoj/doc-update-sprint-3 branch January 31, 2025 10:01
@zyaoj zyaoj mentioned this pull request Jan 31, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick start and Getting started documentation issue
2 participants