Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc on vLLM support #981

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Update doc on vLLM support #981

merged 2 commits into from
Jan 26, 2025

Conversation

MartinGleize
Copy link
Contributor

What does this PR do? Please describe:
Updates the vLLM part of the end-to-end finetuning tutorial.

Does your PR introduce any breaking changes? If yes, please list them:
No

Check list:

  • Was the content of this PR discussed and approved via a GitHub issue? (no need for typos or documentation improvements)
  • Did you read the contributor guideline?
  • Did you make sure that your PR does only one thing instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (no need for typos, documentation, or minor internal changes)

@MartinGleize MartinGleize requested a review from zyaoj as a code owner January 21, 2025 13:06
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 21, 2025
zyaoj
zyaoj reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@zyaoj zyaoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this! LGTM! Just a nit comment then we should be good to go.

doc/source/tutorials/end_to_end_fine_tuning.rst Outdated
**Step 2: Convert XLFormer checkpoint to HF checkpoint**

After obtaining the XLFormer checkpoint, the next step is to convert it to the Hugging Face format. Please refer to the official `HF script`_.
Architecture ``--model`` must exist and be defined in `e.g.` :meth:`fairseq2.models.llama.archs.register_archs`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per the latest refactoring, we should update the :meth:xxx to this new one: https://github.com/facebookresearch/fairseq2/blob/main/src/fairseq2/models/llama/_config.py#L105

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zyaoj , fixed this.

zyaoj
zyaoj approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@zyaoj zyaoj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can probably wait a bit for @cbalioglu to land the refactoring then to merge this together with #993.

@zyaoj zyaoj changed the base branch from main to zyaoj/doc-update-sprint-4 January 26, 2025 11:22
@zyaoj zyaoj mentioned this pull request Jan 26, 2025
Merged
11 tasks
@zyaoj zyaoj merged commit adf453d into facebookresearch:zyaoj/doc-update-sprint-4 Jan 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyaoj zyaoj zyaoj approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinGleize @zyaoj @facebook-github-bot