12 hour inactivity shutdown #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@mojtaba-komeili this type of feature would have been useful for damage control on your issue (though hopefully #911 is helping on the exploration part of that front). |
test/core/test_operator.py
Outdated
| @@ -261,6 +261,50 @@ def test_run_job_not_concurrent(self): | |||
| assignment = task_run.get_assignments()[0] | |||
| self.assertEqual(assignment.get_status(), AssignmentState.COMPLETED) | |||
|
|
|||
| @patch("mephisto.operations.operator.RUN_STATUS_POLL_TIME", 1.5) | |||
| def test_patience_shutdown(self): | |||
| """Ensure that a job can be run that doesn't require connected workers""" | |||
There was a problem hiding this comment.
Not sure id this is the right docstring for this test function.
mojtaba-komeili
approved these changes
Oct 13, 2022
Codecov ReportBase: 64.61% // Head: 64.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
=======================================
Coverage 64.61% 64.61%
=======================================
Files 108 108
Lines 9329 9335 +6
=======================================
+ Hits 6028 6032 +4
- Misses 3301 3303 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the vein of #918 and trying to improve the negative impact of the long tail of failure cases, this feature sets a configurable
submission_patience, which automatically shuts down a MephistoTaskRunwhen no submissions have come through in (by default) 12 hours. This should capture when a task is available but can't be completed (due to a bug in the code, an onboarding that's impossible, pairing problems, etc) and take a task offline before it wastes workers' time.Implementation
no_submission_patienceargument toTaskRunArgslast_submission_timeattribute to theClientIOHandlerwhich is updated every time a submission packet comes in.Operator._track_and_kill_runsto also see if the patience is exceeded as an option for shutting down a task.Testing
Current automated tests pass, and a new test is added for this case too.