[Debug] Adding wrappers around Mephisto's sqlite3 DB access #911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Wraps the creation of
sqlite3
Connection
objects such that, if any thread tries to access them from a different thread, we'll see this behavior occur. This covers all of thesqlite3
connections inside of Mephisto, so @mojtaba-komeili if you still encounter the bug but aren't receiving additional logging, we'll need to look into your task-specific code.At the moment this is only a debug branch, and we may choose to remove later.
NOTE - it's possible that Mephisto is silently swallowing an error somewhere, but the debug logging here should point that out as well.
Testing
Automatic tests - currently failing. Will debug