Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests constructing maps with duplicate custom TimestampWithTimezones #11228

Closed
wants to merge 4 commits into from
Closed

Add tests constructing maps with duplicate custom TimestampWithTimezones #11228

wants to merge 4 commits into from

Commits on Oct 10, 2024

  1. Add tests for array_union and array_remove with TimestampWithTimezone (… 

    …facebookincubator#11222)

Summary:

With facebookincubator#11136 array_union and
array_remove just work with TimestampWithTimezone.

Adding unit tests to verify this and ensure it doesn't break in the future.

Differential Revision: D64196032
    @facebook-github-bot
    Kevin Wilfong authored and facebook-github-bot committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6fd0a89 View commit details
    Browse the repository at this point in the history

  2. Add support for custom comparison in Presto's array_position UDF (fac… 

    …ebookincubator#11226)

Summary:

Update Presto's array_position UDF to work with types that provide custom
comparison (both the 2 and 3 argument flavors).  We can reuse the implementations
for complex types, since that just uses the compare function provided by the Vector. 
With facebookincubator#11022 this just
invokes the Type's custom implementation.

Differential Revision: D64209619
    @facebook-github-bot
    Kevin Wilfong authored and facebook-github-bot committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4f66ae3 View commit details
    Browse the repository at this point in the history

  3. Add support for custom comparison in Presto's contains UDF (facebooki… 

    …ncubator#11227)

Summary:

Update Presto's contains UDF to work with types that provide custom comparison.
We can reuse the implementation for complex types, since that just uses the compare
function provided by the Vector. With 
facebookincubator#11022 this just
invokes the Type's custom implementation.

Differential Revision: D64211715
    @facebook-github-bot
    Kevin Wilfong authored and facebook-github-bot committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a372849 View commit details
    Browse the repository at this point in the history

  4. Add tests constructing maps with duplicate custom TimestampWithTimezones 

    Summary:
When constructing a map in Presto and checking for duplicate keys, it already uses
the key Vector's equalValuesAt function which calls the custom comparison operator
provided by the custom type (if that applies).  So this just works automatically for
types with custom comparison.

Adding unit tests to verify this and ensure it doesn't break in the future.

Differential Revision: D64214359
    @facebook-github-bot
    Kevin Wilfong authored and facebook-github-bot committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4d2c830 View commit details
    Browse the repository at this point in the history