Add tests constructing maps with duplicate custom TimestampWithTimezones #11228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 10, 2024 16:58
…facebookincubator#11222) Summary: With facebookincubator#11136 array_union and array_remove just work with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Differential Revision: D64196032
…ebookincubator#11226) Summary: Update Presto's array_position UDF to work with types that provide custom comparison (both the 2 and 3 argument flavors). We can reuse the implementations for complex types, since that just uses the compare function provided by the Vector. With facebookincubator#11022 this just invokes the Type's custom implementation. Differential Revision: D64209619
…ncubator#11227) Summary: Update Presto's contains UDF to work with types that provide custom comparison. We can reuse the implementation for complex types, since that just uses the compare function provided by the Vector. With facebookincubator#11022 this just invokes the Type's custom implementation. Differential Revision: D64211715
Summary: When constructing a map in Presto and checking for duplicate keys, it already uses the key Vector's equalValuesAt function which calls the custom comparison operator provided by the custom type (if that applies). So this just works automatically for types with custom comparison. Adding unit tests to verify this and ensure it doesn't break in the future. Differential Revision: D64214359
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64214359 |
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request has been merged in 5bedca0. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When constructing a map in Presto and checking for duplicate keys, it already uses
the key Vector's equalValuesAt function which calls the custom comparison operator
provided by the custom type (if that applies). So this just works automatically for
types with custom comparison.
Adding unit tests to verify this and ensure it doesn't break in the future.
Differential Revision: D64214359