Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hwdb adjustments #286

Merged
merged 2 commits into from
Sep 7, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Adjust solution names to systemd review request
Lennart pointed out that the hwdb keys usually do not include dashes and
asked them to be turned into underscores. This change adapts the hwdb
file generated by resctl-bench to that request.

Signed-off-by: Gustavo Noronha Silva <gustavo.noronha@collabora.com>
Gustavo Noronha Silva committed Sep 6, 2022
commit 90cff152ff1f97a49ae87dcc42020deb661d9849
6 changes: 4 additions & 2 deletions resctl-bench/src/bench/iocost_tune.rs
Original file line number Diff line number Diff line change
@@ -2355,10 +2355,12 @@ impl IoCostTuneJob {
.unwrap();

for solution in available_solutions {
let normalized_name = solution.0.to_uppercase().replace("-", "_");

writeln!(
out,
"\n IOCOST_MODEL_{}=rbps={} rseqiops={} rrandiops={} wbps={} wseqiops={} wrandiops={}",
solution.0.to_uppercase(),
normalized_name,
solution.1.model.rbps,
solution.1.model.rseqiops,
solution.1.model.rrandiops,
@@ -2372,7 +2374,7 @@ impl IoCostTuneJob {
write!(
out,
" IOCOST_QOS_{}=rpct={:.2} rlat={} wpct={:.2} wlat={} min={:.2} max={:.2}",
solution.0.to_uppercase(),
normalized_name,
solution.1.qos.rpct,
solution.1.qos.rlat,
solution.1.qos.wpct,