Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hwdb adjustments #286

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Hwdb adjustments #286

merged 2 commits into from
Sep 7, 2022

Conversation

kov
Copy link

@kov kov commented Sep 6, 2022

This is basically to adapt the hwdb file that gets generated to requests made by the systemd maintainers. I am also including a commit to add the rlat solutions as we had agreed and I forgot for the initial merge. This is what the hwdb entry for a device looks like:

block:*:name:MZUL2256HCHQ-00AFB:
  IOCOST_SOLUTIONS=isolation isolated-bandwidth bandwidth naive
  IOCOST_MODEL_ISOLATION=rbps=626708081 rseqiops=27119 rrandiops=26638 wbps=138402498 wseqiops=3257 wrandiops=3208
  IOCOST_QOS_ISOLATION=rpct=0.00 rlat=1997 wpct=0.00 wlat=50837 min=100.00 max=100.00
  IOCOST_MODEL_ISOLATED_BANDWIDTH=rbps=997831946 rseqiops=43179 rrandiops=42412 wbps=220361662 wseqiops=5186 wrandiops=5107
  IOCOST_QOS_ISOLATED_BANDWIDTH=rpct=0.00 rlat=2213 wpct=0.00 wlat=61487 min=100.00 max=100.00
  IOCOST_MODEL_BANDWIDTH=rbps=1891663391 rseqiops=81857 rrandiops=80403 wbps=417755805 wseqiops=9832 wrandiops=9682
  IOCOST_QOS_BANDWIDTH=rpct=0.00 rlat=7034 wpct=0.00 wlat=87136 min=100.00 max=100.00
  IOCOST_MODEL_NAIVE=rbps=1891663391 rseqiops=81857 rrandiops=80403 wbps=417755805 wseqiops=9832 wrandiops=9682
  IOCOST_QOS_NAIVE=rpct=99.00 rlat=7034 wpct=99.00 wlat=87136 min=75.00 max=100.00
  IOCOST_MODEL_RLAT_99_Q1=rbps=1891663391 rseqiops=81857 rrandiops=80403 wbps=417755805 wseqiops=9832 wrandiops=9682
  IOCOST_QOS_RLAT_99_Q1=rpct=99.00 rlat=7034 wpct=0.00 wlat=0 min=87.66 max=100.00
  IOCOST_MODEL_RLAT_99_Q2=rbps=1658184837 rseqiops=71754 rrandiops=70479 wbps=366194295 wseqiops=8618 wrandiops=8487
  IOCOST_QOS_RLAT_99_Q2=rpct=99.00 rlat=5775 wpct=0.00 wlat=0 min=85.92 max=100.00
  IOCOST_MODEL_RLAT_99_Q3=rbps=1424706283 rseqiops=61651 rrandiops=60556 wbps=314632785 wseqiops=7405 wrandiops=7292
  IOCOST_QOS_RLAT_99_Q3=rpct=99.00 rlat=4515 wpct=0.00 wlat=0 min=83.61 max=100.00
  IOCOST_MODEL_RLAT_99_Q4=rbps=1191227729 rseqiops=51547 rrandiops=50632 wbps=263071274 wseqiops=6191 wrandiops=6097
  IOCOST_QOS_RLAT_99_Q4=rpct=99.00 rlat=3256 wpct=0.00 wlat=0 min=80.40 max=100.00

Gustavo Noronha Silva added 2 commits September 6, 2022 11:33
Lennart pointed out that the hwdb keys usually do not include dashes and
asked them to be turned into underscores. This change adapts the hwdb
file generated by resctl-bench to that request.

Signed-off-by: Gustavo Noronha Silva <gustavo.noronha@collabora.com>
Signed-off-by: Gustavo Noronha Silva <gustavo.noronha@collabora.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2022
@htejun htejun merged commit 7d2c663 into facebookexperimental:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants