Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initialization of clevel to static cdict (#3525) #3527

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

yoniko
Copy link
Contributor

@yoniko yoniko commented Mar 7, 2023

  • Initializes clevel in ZSTD_CCtxParams_init
  • Adds CI workflow for msan fuzzers runs without optimization (-O0)
  • Fixes Makefile to correctly pass on user defined MOREFLAGS and FUZZER_FLAGS in cases they have been overwritten

UPDATE: CI failed without the fix, fix is now enabled

@yoniko
Copy link
Contributor Author

yoniko commented Mar 7, 2023

clang-msan-fuzz-unoptimized has failed as expected, verifying that the new CI flow does catch the issue. Going to amend the fix to make sure all CI tests pass now.

- Initializes clevel in `ZSTD_CCtxParams_init`
- Adds CI workflow for msan fuzzers runs without optimization (`-O0`)
- Fixes Makefile to correctly pass on user defined `MOREFLAGS` and `FUZZER_FLAGS` in cases they have been overwritten
@yoniko yoniko force-pushed the fix-3525-static-cdict-clevel-init branch from 2473df2 to 6ef471f Compare March 7, 2023 01:13
@yoniko yoniko merged commit 988ce61 into facebook:dev Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants