-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZSTD_initStaticCDict does not set level and it results in use of uninit value #3525
Labels
Comments
Thank you for reporting @danlark1.
I'll add initialization and verify that we cover this case in CI. |
yoniko
added a commit
to yoniko/zstd
that referenced
this issue
Mar 7, 2023
- Initializes clevel in `ZSTD_CCtxParams_init` (NOTE: currently commented out to verify CI failure, will be amended) - Adds CI workflow for msan fuzzers runs without optimization (`-O0`) - Fixes Makefile to correctly pass on user defined `MOREFLAGS` and `FUZZER_FLAGS` in cases they have been overwritten
yoniko
added a commit
to yoniko/zstd
that referenced
this issue
Mar 7, 2023
- Initializes clevel in `ZSTD_CCtxParams_init` - Adds CI workflow for msan fuzzers runs without optimization (`-O0`) - Fixes Makefile to correctly pass on user defined `MOREFLAGS` and `FUZZER_FLAGS` in cases they have been overwritten
yoniko
added a commit
that referenced
this issue
Mar 7, 2023
- Initializes clevel in `ZSTD_CCtxParams_init` - Adds CI workflow for msan fuzzers runs without optimization (`-O0`) - Fixes Makefile to correctly pass on user defined `MOREFLAGS` and `FUZZER_FLAGS` in cases they have been overwritten
It works, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
ZSTD_initStaticCDict does not set compression level
To Reproduce
While running under msan, we found an error
This is the error
ZSTD_CCtxParams_init_internal(&cctxParams, ¶ms, cdict->compressionLevel);
cdict->compressionLevel was not set during initialization
Expected behavior
No msan error
Desktop (please complete the following information):
Additional context
Should be easy to fix
The text was updated successfully, but these errors were encountered: