Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ style enums 16/N: Dimension #1403

Closed
wants to merge 1 commit into from
Closed

C++ style enums 16/N: Dimension #1403

wants to merge 1 commit into from

Commits on Sep 29, 2023

  1. C++ style enums 16/N: Dimension (facebook#1403) 

    Summary:
X-link: facebook/react-native#39598


Replaces all usages of YGDimension with Dimension.

Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23.

This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D49475409
    @NickGerleman @facebook-github-bot
    NickGerleman authored and facebook-github-bot committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    236e8ea View commit details
    Browse the repository at this point in the history