C++ style enums 16/N: Dimension #1403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39598 X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: c0f643b2a590ee09264def51da24af224d1bff17
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 26, 2023
Summary: X-link: facebook/react-native#39598 Pull Request resolved: facebook#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 56688d703cf1149740e3b689d32c8fd24d2b2413
NickGerleman
force-pushed
the
export-D49475409
branch
from
0ed5a8f
to
a53aee9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 26, 2023
Summary: X-link: facebook/react-native#39598 Pull Request resolved: facebook#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 6c71d79381c1987c1b504dc1de314116788b1d35
NickGerleman
force-pushed
the
export-D49475409
branch
from
a53aee9
to
c1b9ca2
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39598 X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: f268ce2c3e90986559ef3e49d00a5fb122c2ce18
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 28, 2023
Summary: X-link: facebook/react-native#39598 Pull Request resolved: facebook#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: bc8ba256bfcd1e89b0fa1562e282cbc4dab4a7ee
NickGerleman
force-pushed
the
export-D49475409
branch
from
c1b9ca2
to
195b728
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: facebook#39598 X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 6545a948a90f0d63a00fac20a515d03df8694a1b
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 28, 2023
Summary: X-link: facebook/react-native#39598 Pull Request resolved: facebook#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 53c25f2e0f58db633e1a78095dc7b8561e9b7921
NickGerleman
force-pushed
the
export-D49475409
branch
from
195b728
to
fc60f14
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: facebook#39598 X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 6aee39d7c23e2a2a23fdced36d1ec5924576e457
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 28, 2023
Summary: X-link: facebook/react-native#39598 Pull Request resolved: facebook#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: c63c4662e63bd7f81369596215ab7b15a0afd051
NickGerleman
force-pushed
the
export-D49475409
branch
from
fc60f14
to
74cb42c
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: facebook#39598 X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 505d93803baf7680c9f606cc5f7fcff7f0b2c118
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/react-native#39598 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
force-pushed
the
export-D49475409
branch
from
74cb42c
to
2b0755f
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
Summary: X-link: facebook/react-native#39598 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/react-native#39598 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
force-pushed
the
export-D49475409
branch
from
2b0755f
to
dfe8110
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
force-pushed
the
export-D49475409
branch
from
dfe8110
to
236e8ea
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
|
This pull request has been merged in a8566a0. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/react-native#39598 X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 7d4c31e8a84485baea0dab50b5cf16b86769fa07
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 29, 2023
Summary: Pull Request resolved: #39598 X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 7d4c31e8a84485baea0dab50b5cf16b86769fa07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Replaces all usages of YGDimension with Dimension.
Adds
yoga::to_underlyingto act likestd::to_underlying, added in C++ 23.This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there.
Differential Revision: D49475409