Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add tests unintentionally deleted in #9209 #9225

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Mar 20, 2017

These tests are useful and don't test addons specifically.
I moved them to appropriate places in the codebase.

These tests are useful and don't test addons specifically.
I moved them to appropriate places in the codebase.
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the build passes, this looks good to me.

@gaearon
Copy link
Collaborator Author

gaearon commented Mar 20, 2017

Fairly confident this works. I ran everything locally.

@gaearon gaearon merged commit e15a481 into facebook:master Mar 20, 2017
@gaearon gaearon deleted the add-deleted-test-back branch March 20, 2017 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants