Delete addons #9209
Merged
Delete addons #9209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
force-pushed
the
delete-addons
branch
2 times, most recently
from
e973929 to
b219f63
Compare
sophiebits
reviewed
Mar 18, 2017
| @@ -68,7 +66,7 @@ describe('onlyChild', () => { | |||
| expect(function() { | |||
| var instance = ( | |||
| <WrapComponent> | |||
| {ReactFragment.create({oneThing: <span />})} | |||
| {{oneThing: <span />}} | |||
There was a problem hiding this comment.
Can you change this to have a single child [<span />] instead?
gaearon
added a commit
to gaearon/react
that referenced
this pull request
Mar 20, 2017
These tests are useful and don't test addons specifically. I moved them to appropriate places in the codebase.
gaearon
added a commit
that referenced
this pull request
Mar 20, 2017
gaearon
pushed a commit
that referenced
this pull request
Jun 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m deleting addons packages (and a few other abandoned packages) and “React with addons” UMD build on master. See #9207 for rationale and the plan.
We will be releasing 15.5 with some updates to addons, and some deprecations (as explained in #9207) but we'll be cutting it from a branch since it diverged too much already. I’d like to delete them in master so that we can fork a copy in www for old code that still depends on them.
Note this means that 15.5 release must be done manually and not with the release manager.
TODO: