Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Brunch build tool to the docs #9074

Merged
merged 3 commits into from
Mar 3, 2017
Merged

Added Brunch build tool to the docs #9074

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a08d8ff
Added Brunch build tool to the docs
beznosd Feb 27, 2017
455e0bb
Improved grammar
beznosd Mar 3, 2017
dadd79d
product build -> production build
Mar 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/docs/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ By default, React includes many helpful warnings. These warnings are very useful

If you use [Create React App](https://github.com/facebookincubator/create-react-app), `npm run build` will create an optimized build of your app in the `build` folder.

#### Brunch

Just add flag `-p` to the command to create an optimized production build.
For example: `brunch build -p`. See more details in [Brunch docs](http://brunch.io/docs/commands) commands section.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this ensure process.env.NODE_ENV get envified?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rephrase this to:

To create an optimized product build with Brunch, just add the -p flag to the build command. See the Brunch docs for more details.


#### Webpack

Include both `DefinePlugin` and `UglifyJsPlugin` into your production Webpack configuration as described in [this guide](https://webpack.js.org/guides/production-build/).
Expand Down
1 change: 1 addition & 0 deletions docs/docs/optimizing-performance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ If you're benchmarking or experiencing performance problems in your React apps,

* For Create React App, you need to run `npm run build` and follow the instructions.
* For single-file builds, we offer production-ready `.min.js` versions.
* For Brunch, you need to add flag `-p` to the command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets rephrase to:

For Brunch, you need to add the -p flag to the build command.

* For Browserify, you need to run it with `NODE_ENV=production`.
* For Webpack, you need to add this to plugins in your production config:

Expand Down