Added Brunch build tool to the docs #9074
Conversation
docs/docs/installation.md
Outdated
| #### Brunch | ||
|
|
||
| Just add flag `-p` to the command to create an optimized production build. | ||
| For example: `brunch build -p`. See more details in [Brunch docs](http://brunch.io/docs/commands) commands section. |
There was a problem hiding this comment.
Does this ensure process.env.NODE_ENV get envified?
docs/docs/installation.md
Outdated
| #### Brunch | ||
|
|
||
| Just add flag `-p` to the command to create an optimized production build. | ||
| For example: `brunch build -p`. See more details in [Brunch docs](http://brunch.io/docs/commands) commands section. |
There was a problem hiding this comment.
Let's rephrase this to:
To create an optimized product build with Brunch, just add the
-pflag to thebuildcommand. See the Brunch docs for more details.
docs/docs/optimizing-performance.md
Outdated
| @@ -13,6 +13,7 @@ If you're benchmarking or experiencing performance problems in your React apps, | |||
|
|
|||
| * For Create React App, you need to run `npm run build` and follow the instructions. | |||
| * For single-file builds, we offer production-ready `.min.js` versions. | |||
| * For Brunch, you need to add flag `-p` to the command. | |||
There was a problem hiding this comment.
Lets rephrase to:
For Brunch, you need to add the
-pflag to thebuildcommand.
|
Thanks @beznosd, looks great! I realized I had a typo in my recommended changes so I went ahead and fixed it for you. Sorry about that 😄 |
|
Cool! It's okay. Thanks @aweary! |
|
@aweary Can you send a PR that reorders them by alphabet, except for CRA which should go first? Otherwise it's a bit odd that Brunch goes first considering it's much less popular in the React community. |
* Added Brunch build tool to the docs * Improved grammar * product build -> production build (cherry picked from commit 0bedd06)
Added Brunch to this articles:
https://facebook.github.io/react/docs/installation.html#development-and-production-versions
https://facebook.github.io/react/docs/optimizing-performance.html#use-the-production-build