Update all Jest packages to 17.x #8327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can just remove the CI caches, would that help? |
quantizor
changed the title
|
It's all good @gaearon, from what I can see the impact is negligible and it causes first run to be 50% slower which is poor DX. |
|
Looks like it's getting stuck on the fiber tests. I'm without a computer for a few days, but will take a look on Saturday. |
keyz
reviewed
Nov 18, 2016
| "jest-jasmine2": "^15.1.1", | ||
| "jest-runtime": "^15.1.1", | ||
| "jest": "^17.0.2", | ||
| "jest-cli": "17.0.2", |
There was a problem hiding this comment.
jest just exports jest-cli (https://github.com/facebook/jest/blob/master/packages/jest/src/jest.js) so only one of them would be enough here.
Looking at the other builds it doesn't seem to actually be that necessary. The bottleneck is executors, not build time.
quantizor
force-pushed
the
jest-update
branch
from
ce5dea2 to
8694d3a
Compare
quantizor
commented
Nov 20, 2016
| const TestRunner = require('jest').TestRunner; | ||
| const SearchSource = require('jest-cli').SearchSource; | ||
| const TestRunner = require('jest-cli').TestRunner; | ||
| const TestWatcher = require('jest-cli/build/TestWatcher'); |
There was a problem hiding this comment.
There is a PR open to remove the need to delve into internals. jestjs/jest#2138
|
@gaearon / @keyanzhang this should be good now. Thanks for the feedback! |
|
I already fixed it. See the 2 most recent commits. |
|
Looks great, thanks! |
jackjocross
added a commit
to jackjocross/react
that referenced
this pull request
Jan 13, 2017
* Update all Jest packages to 17.x, cache babel-jest transforms * Remove the caching Looking at the other builds it doesn't seem to actually be that necessary. The bottleneck is executors, not build time. * Remove unnecessary package, fix fiber test runner * Regenerate yarn lockfile
gaearon
pushed a commit
that referenced
this pull request
Jan 23, 2017
* devDependencies: add core-js and es6-symbol polyfill for tests * Update Flow and fix issues (#8006) * Add npm v4.0.0 support (#8082) * Add support for node v7 (#8135) * Upgrade ESLint and dependencies, fix new lint errors, switch Travis to Yarn (#8309) * Update ESLint to 3.10.2 Also pull in fbjs for extending properly, per @zpao. This also disables consistent-return, which has about 80 failing cases in React currently. If we'd like to turn this back on, we should do it separately and fix all the call sites properly (rather than just adding 'return undefined;' everywhere, which adds no value. Fixes to all existing lint errors plus an update for yarn.lock to follow. * Update yarn.lock after the eslint update. * Fix all new eslint failures Unfortunately I had to add three eslint-disable-next-line instances. All have explanations inline. * Switch Travis to use yarn instead of npm * Update all Jest packages to 17.x (#8327) * Update all Jest packages to 17.x, cache babel-jest transforms * Remove the caching Looking at the other builds it doesn't seem to actually be that necessary. The bottleneck is executors, not build time. * Remove unnecessary package, fix fiber test runner * Regenerate yarn lockfile * Update Flow to 0.37.0 (#8608) Nothing really changes. * Update to Jest 18 (#8621) * mockImpl -> mockImplementation D4329549 * Fixed linting errors * circle.yml and circleci scripts * Update Flow and fix issues (#8006) * Fixed flow errors * Updated shrinkwrap * Removed unnecessary change * Added jest --runInBand flag * Removed ReactDOMFiber changes
gaearon
pushed a commit
that referenced
this pull request
Jan 23, 2017
* devDependencies: add core-js and es6-symbol polyfill for tests * Update Flow and fix issues (#8006) * Add npm v4.0.0 support (#8082) * Add support for node v7 (#8135) * Upgrade ESLint and dependencies, fix new lint errors, switch Travis to Yarn (#8309) * Update ESLint to 3.10.2 Also pull in fbjs for extending properly, per @zpao. This also disables consistent-return, which has about 80 failing cases in React currently. If we'd like to turn this back on, we should do it separately and fix all the call sites properly (rather than just adding 'return undefined;' everywhere, which adds no value. Fixes to all existing lint errors plus an update for yarn.lock to follow. * Update yarn.lock after the eslint update. * Fix all new eslint failures Unfortunately I had to add three eslint-disable-next-line instances. All have explanations inline. * Switch Travis to use yarn instead of npm * Update all Jest packages to 17.x (#8327) * Update all Jest packages to 17.x, cache babel-jest transforms * Remove the caching Looking at the other builds it doesn't seem to actually be that necessary. The bottleneck is executors, not build time. * Remove unnecessary package, fix fiber test runner * Regenerate yarn lockfile * Update Flow to 0.37.0 (#8608) Nothing really changes. * Update to Jest 18 (#8621) * mockImpl -> mockImplementation D4329549 * Fixed linting errors * circle.yml and circleci scripts * Update Flow and fix issues (#8006) * Fixed flow errors * Updated shrinkwrap * Removed unnecessary change * Added jest --runInBand flag * Removed ReactDOMFiber changes
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
* Update all Jest packages to 17.x, cache babel-jest transforms * Remove the caching Looking at the other builds it doesn't seem to actually be that necessary. The bottleneck is executors, not build time. * Remove unnecessary package, fix fiber test runner * Regenerate yarn lockfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caching is mostly for CI speediness, users won't see more than a few seconds of improvement.It did not help in any useful way, so dropped that portion of the PR.