Update Flow and fix issues #8006

gaearon · 2016-10-18T13:47:31Z

This updates Flow and fixes issues I found trying to sync React to www.

gaearon · 2016-10-18T13:48:19Z

src/renderers/testing/ReactTestMount.js

 export type TestRendererOptions = {
-  createNodeMock: (element: ReactElement) => any,
+  createNodeMock: (element: ReactElement<any>) => any,
 };


This is public API so I needed to use the "public" ReactElement definition provided by Flow. Otherwise tests in www fail.

I don’t have a good understanding of the difference between ReactElement<*> and ReactElement<any>, though I think that ReactElement<*> allows Flow to infer more. Does that matter or nah?

I don't understand either 😄 . But at least it passes.

gaearon · 2016-10-18T13:48:33Z

src/renderers/shared/stack/reconciler/ReactInstanceType.js

+  receiveComponent: any,
+  getName: () => string,
+  getPublicInstance: any,
+  _currentElement: ReactElement,


The only change is adding _currentElement here.

With the Shared comment it looks like this is saying that the lifecycles are shared between the ReactCompositeComponent and ReactDOMComponent. Is that true?

Yes, those methods are shared. mountComponent/receiveComponent/unmountComponent is the "base" component API, DOMComponent and CompositeComponent implement it in different ways.

gaearon · 2016-10-18T13:48:50Z

src/renderers/native/NativeMethodsMixin.js

@@ -212,7 +212,7 @@ function mountSafeCallback(
  callback: ?Function
 ): any {
  return function() {
-    if (!callback || (context.isMounted && !context.isMounted())) {
+    if (!callback || (typeof context.isMounted === 'function' && !context.isMounted())) {


Flow now errors on calling non-callables.

shouldn’t Flow understand this to be a function if it exists? https://github.com/facebook/flow/blob/master/lib/react.js#L74

¯_(ツ)_/¯

iamdustan · 2016-10-18T13:51:56Z

This supersedes @jeffmo’s PR #7841?

gaearon · 2016-10-18T13:53:52Z

I didn't see that one but it looks like mine fixed the issues in it so yes.

gaearon · 2016-10-18T13:55:39Z

@iamdustan Can you review this plz?

iamdustan · 2016-10-18T13:56:46Z

If by review you mean ask a lot of questions: sure 😄

gaearon · 2016-10-18T13:57:33Z

I want to get this in but everybody is asleep. I trust your judgement, just me know if changes look correct to you and I'll merge.

gaearon · 2016-10-18T14:00:50Z

Uh. Why can't I reproduce this locally?

iamdustan · 2016-10-18T14:09:14Z

npm install compared to yarn install?

chicoxyzzy · 2016-10-18T14:09:38Z

@gaearon facebook/flow#2548 (comment)

gaearon · 2016-10-18T14:09:45Z

I ran npm install locally. Will try again.

gaearon · 2016-10-18T14:10:07Z

@chicoxyzzy I found that one but then I don't understand how #7841 passed.

iamdustan · 2016-10-18T14:15:00Z

My current thinking on why this passed locally but not on Travis is because travis had cached the previous npm install with fbjs@0.8.4 and bumping to 0.8.5 forced travis to update.

iamdustan · 2016-10-18T14:15:59Z

This change looks legit to me.

gaearon · 2016-10-18T14:21:04Z

@iamdustan Thanks!

@zpao

* devDependencies: add core-js and es6-symbol polyfill for tests * Update Flow and fix issues (#8006) * Add npm v4.0.0 support (#8082) * Add support for node v7 (#8135) * Upgrade ESLint and dependencies, fix new lint errors, switch Travis to Yarn (#8309) * Update ESLint to 3.10.2 Also pull in fbjs for extending properly, per @zpao. This also disables consistent-return, which has about 80 failing cases in React currently. If we'd like to turn this back on, we should do it separately and fix all the call sites properly (rather than just adding 'return undefined;' everywhere, which adds no value. Fixes to all existing lint errors plus an update for yarn.lock to follow. * Update yarn.lock after the eslint update. * Fix all new eslint failures Unfortunately I had to add three eslint-disable-next-line instances. All have explanations inline. * Switch Travis to use yarn instead of npm * Update all Jest packages to 17.x (#8327) * Update all Jest packages to 17.x, cache babel-jest transforms * Remove the caching Looking at the other builds it doesn't seem to actually be that necessary. The bottleneck is executors, not build time. * Remove unnecessary package, fix fiber test runner * Regenerate yarn lockfile * Update Flow to 0.37.0 (#8608) Nothing really changes. * Update to Jest 18 (#8621) * mockImpl -> mockImplementation D4329549 * Fixed linting errors * circle.yml and circleci scripts * Update Flow and fix issues (#8006) * Fixed flow errors * Updated shrinkwrap * Removed unnecessary change * Added jest --runInBand flag * Removed ReactDOMFiber changes

@zpao

* devDependencies: add core-js and es6-symbol polyfill for tests * Update Flow and fix issues (#8006) * Add npm v4.0.0 support (#8082) * Add support for node v7 (#8135) * Upgrade ESLint and dependencies, fix new lint errors, switch Travis to Yarn (#8309) * Update ESLint to 3.10.2 Also pull in fbjs for extending properly, per @zpao. This also disables consistent-return, which has about 80 failing cases in React currently. If we'd like to turn this back on, we should do it separately and fix all the call sites properly (rather than just adding 'return undefined;' everywhere, which adds no value. Fixes to all existing lint errors plus an update for yarn.lock to follow. * Update yarn.lock after the eslint update. * Fix all new eslint failures Unfortunately I had to add three eslint-disable-next-line instances. All have explanations inline. * Switch Travis to use yarn instead of npm * Update all Jest packages to 17.x (#8327) * Update all Jest packages to 17.x, cache babel-jest transforms * Remove the caching Looking at the other builds it doesn't seem to actually be that necessary. The bottleneck is executors, not build time. * Remove unnecessary package, fix fiber test runner * Regenerate yarn lockfile * Update Flow to 0.37.0 (#8608) Nothing really changes. * Update to Jest 18 (#8621) * mockImpl -> mockImplementation D4329549 * Fixed linting errors * circle.yml and circleci scripts * Update Flow and fix issues (#8006) * Fixed flow errors * Updated shrinkwrap * Removed unnecessary change * Added jest --runInBand flag * Removed ReactDOMFiber changes

facebook-github-bot added GH Review: review-needed CLA Signed labels Oct 18, 2016

gaearon commented Oct 18, 2016

View reviewed changes

gaearon mentioned this pull request Oct 18, 2016

Update to Flow v0.33.0 #7841

Closed

Update Flow and fix issues

07f4ad5

gaearon added GH Review: accepted and removed GH Review: review-needed labels Oct 18, 2016

gaearon added this to the 15-next milestone Oct 18, 2016

gaearon added the semver-exempt label Oct 18, 2016

gaearon merged commit 9bfa45b into facebook:master Oct 18, 2016

gaearon deleted the update-flow branch October 18, 2016 14:26

gaearon removed this from the 15-next milestone Jan 6, 2017

gaearon added semver-exempt and removed semver-exempt labels Jan 6, 2017

jackjocross added a commit to jackjocross/react that referenced this pull request Jan 13, 2017

Update Flow and fix issues (facebook#8006)

ad9b3c2

jackjocross pushed a commit to jackjocross/react that referenced this pull request Jan 13, 2017

Update Flow and fix issues (facebook#8006)

b97dcd5

acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017

Update Flow and fix issues (facebook#8006)

3c7873e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Flow and fix issues #8006

Update Flow and fix issues #8006

gaearon commented Oct 18, 2016

gaearon Oct 18, 2016

iamdustan Oct 18, 2016

gaearon Oct 18, 2016

gaearon Oct 18, 2016

iamdustan Oct 18, 2016

gaearon Oct 18, 2016 •

edited

Loading

gaearon Oct 18, 2016

iamdustan Oct 18, 2016

gaearon Oct 18, 2016

iamdustan commented Oct 18, 2016

gaearon commented Oct 18, 2016

gaearon commented Oct 18, 2016

iamdustan commented Oct 18, 2016

gaearon commented Oct 18, 2016

gaearon commented Oct 18, 2016

iamdustan commented Oct 18, 2016

chicoxyzzy commented Oct 18, 2016

gaearon commented Oct 18, 2016

gaearon commented Oct 18, 2016

iamdustan commented Oct 18, 2016

iamdustan commented Oct 18, 2016

gaearon commented Oct 18, 2016

Update Flow and fix issues #8006

Update Flow and fix issues #8006

Conversation

gaearon commented Oct 18, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaearon Oct 18, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamdustan commented Oct 18, 2016

gaearon commented Oct 18, 2016

gaearon commented Oct 18, 2016

iamdustan commented Oct 18, 2016

gaearon commented Oct 18, 2016

gaearon commented Oct 18, 2016

iamdustan commented Oct 18, 2016

chicoxyzzy commented Oct 18, 2016

gaearon commented Oct 18, 2016

gaearon commented Oct 18, 2016

iamdustan commented Oct 18, 2016

iamdustan commented Oct 18, 2016

gaearon commented Oct 18, 2016

gaearon Oct 18, 2016 •

edited

Loading