Add support all lifecycle methods to ShallowRender #7912
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a breaking change.
Supporting all lifecycle methods in ShallowRender merged at #4993, but reverted at #5394.
The reason why the PR is reverted is that it didn't support string
refs
.This PR is fixed it.
Currently, ShallowRender is replacing
_renderValidatedComponent
with_renderValidatedComponentWithoutOwnerOrContext
, which it seems to be a little hacky.I think it's better to assign
null
to_onwer
filed.