Run all component lifecycle methods when shallow rendering #4993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks good. Probably we'll wait until after 0.14 is released to merge this though. |
|
+1 This will be so great. |
sophiebits
added a commit
that referenced
this pull request
Nov 3, 2015
Run all component lifecycle methods when shallow rendering
|
Thanks! |
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Nov 3, 2015
chicoxyzzy
pushed a commit
to chicoxyzzy/react
that referenced
this pull request
Nov 4, 2015
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Nov 5, 2015
We were shallow-rendering a component that used refs at FB so this can't go in as-is. It's a little unclear what we _should_ do though, since there is nothing to hold a ref to (since we're shallowly rendering) and we generally promise that child refs are resolved before a parent's componentDidMount. Also, changing shallow rendering to use the original `_renderValidatedComponent` (instead of `_renderValidatedComponentWithoutOwnerOrContext`) breaks tests because now the `_owner` field doesn't match up for `toEqual` (non-null in `getRenderOutput` but null if constructed in a test).
|
I'm going to have to revert this in #5394, sorry – more details there. |
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Nov 5, 2015
We were shallow-rendering a component that used refs at FB so this can't go in as-is. It's a little unclear what we _should_ do though, since there is nothing to hold a ref to (since we're shallowly rendering) and we generally promise that child refs are resolved before a parent's componentDidMount. Also, changing shallow rendering to use the original `_renderValidatedComponent` (instead of `_renderValidatedComponentWithoutOwnerOrContext`) breaks tests because now the `_owner` field doesn't match up for `toEqual` (non-null in `getRenderOutput` but null if constructed in a test).
sophiebits
added a commit
that referenced
this pull request
Nov 5, 2015
Revert #4993 with an added test for refs
jankuca
added a commit
to jankuca/react-test-render
that referenced
this pull request
Dec 11, 2015
`ReactShallowRenderer` does not call all lifecycle methods – namely `componentDidMount` and `componentDidUpdate`. This patch fixes this until real support lands in the official React codebase. Addresses facebook/react#4993 “Run all component lifecycle methods when shallow rendering”
|
any plan to re-implement such a feature into the shallow renderer? |
|
As I mentioned in the linked pull request, it's a little unclear how shallow rendering should work with lifecycle methods, especially with refs, since there is nothing to hold a ref to (since we're shallowly rendering) and we usually promise that child refs are resolved before a parent's componentDidMount. If someone proposes a solution that doesn't have this problem I'm happy to entertain it. |
|
I haven't had much time to work on this, but the ideas I had were
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs transaction around shallow render so remaining component lifecycle methods (componentDidMount, componentDidUpdate) are processed.
Fixes #4919