feat: display message if user ended up opening hook script #31000
+56
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
hoxyq
force-pushed
the
react-devtools/hook-source-map-to-have-a-message
branch
from
d83cde3
to
3bfb849
Compare
hoxyq
force-pushed
the
react-devtools/hook-source-map-to-have-a-message
branch
from
3bfb849
to
2885f60
Compare
vzaidman
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #30596 we've moved console patching to the global hook. Generally speaking, the patching happens even before React is loaded on the page.
If browser DevTools were opened after when
console.errororconsole.warnwere called, the source script will behook.js, because of the patching.This is because ignore listing is not applied retroactively by Chrome DevTools.
If you had it open before console calls, Hook script would be correctly filtered out from the stack:
I had hopes that the fix for https://issues.chromium.org/issues/345248263 will also apply ignore listing retroactively, but looks like we need to open a separate feature request for the Chrome DevTools team.
With these changes, if user attempts to open
hook.jsscript, they are going to see this message: